2022-04-07 19:53:32

by Usyskin, Alexander

Subject: [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

Add slow_fw flag to the mei auxiliary device info
to inform the mei driver about slow underlying firmware.
Such firmware will require to use larger operation timeouts.

Signed-off-by: Alexander Usyskin <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
---
include/linux/mei_aux.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
index 587f25128848..a29f4064b9c0 100644
--- a/include/linux/mei_aux.h
+++ b/include/linux/mei_aux.h
@@ -11,6 +11,7 @@ struct mei_aux_device {
struct auxiliary_device aux_dev;
int irq;
struct resource bar;
+ bool slow_fw;
};

#define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \
--
2.32.0

2022-04-12 16:31:48

by Daniele Ceraolo Spurio

Subject: Re: [Intel-gfx] [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

On 4/7/2022 5:58 AM, Alexander Usyskin wrote:
> Add slow_fw flag to the mei auxiliary device info
> to inform the mei driver about slow underlying firmware.
> Such firmware will require to use larger operation timeouts.
>
> Signed-off-by: Alexander Usyskin <[email protected]>
> Signed-off-by: Tomas Winkler <[email protected]>

Might be worth squashing this in one of the patches that makes use of
it, but I can see the benefit of having the interface added in a patch
that's neither mei nor i915.

Reviewed-by: Daniele Ceraolo Spurio <[email protected]>

> ---
> include/linux/mei_aux.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> index 587f25128848..a29f4064b9c0 100644
> --- a/include/linux/mei_aux.h
> +++ b/include/linux/mei_aux.h
> @@ -11,6 +11,7 @@ struct mei_aux_device {
> struct auxiliary_device aux_dev;
> int irq;
> struct resource bar;
> + bool slow_fw;
> };
>
> #define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \