2019-10-02 17:45:20

by Krzysztof Kozlowski

Subject: [PATCH] dt-bindings: memory-controllers: exynos5422-dmc: Correct example syntax and memory region

After adding the interrupt properties to Exynos5422 DMC bindings
example, the mapped memory region must be big enough to access
performance counters registers.

Fix also syntax errors (semicolons) and adjust indentation.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Rebased on top of my for-next branch as exynos5422-dmc.txt bindings were
applied by me.
---
.../bindings/memory-controllers/exynos5422-dmc.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
index e2434cac4858..02e4a1f862f1 100644
--- a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
+++ b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
@@ -55,7 +55,7 @@ Example:

dmc: memory-controller@10c20000 {
compatible = "samsung,exynos5422-dmc";
- reg = <0x10c20000 0x100>, <0x10c30000 0x100>,
+ reg = <0x10c20000 0x10000>, <0x10c30000 0x10000>;
clocks = <&clock CLK_FOUT_SPLL>,
<&clock CLK_MOUT_SCLK_SPLL>,
<&clock CLK_FF_DOUT_SPLL2>,
@@ -63,7 +63,7 @@ Example:
<&clock CLK_MOUT_BPLL>,
<&clock CLK_SCLK_BPLL>,
<&clock CLK_MOUT_MX_MSPLL_CCORE>,
- <&clock CLK_MOUT_MCLK_CDREX>,
+ <&clock CLK_MOUT_MCLK_CDREX>;
clock-names = "fout_spll",
"mout_sclk_spll",
"ff_dout_spll2",
@@ -71,10 +71,10 @@ Example:
"mout_bpll",
"sclk_bpll",
"mout_mx_mspll_ccore",
- "mout_mclk_cdrex",
+ "mout_mclk_cdrex";
operating-points-v2 = <&dmc_opp_table>;
devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>,
- <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>;
+ <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>;
device-handle = <&samsung_K3QF2F20DB>;
vdd-supply = <&buck1_reg>;
samsung,syscon-clk = <&clock>;
--
2.17.1

2019-10-03 06:16:41

by Lukasz Luba

Subject: Re: [PATCH] dt-bindings: memory-controllers: exynos5422-dmc: Correct example syntax and memory region

Hi Krzysztof,

On 10/2/19 7:44 PM, Krzysztof Kozlowski wrote:
> After adding the interrupt properties to Exynos5422 DMC bindings
> example, the mapped memory region must be big enough to access
> performance counters registers.
>
> Fix also syntax errors (semicolons) and adjust indentation.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Rebased on top of my for-next branch as exynos5422-dmc.txt bindings were
> applied by me.
> ---
> .../bindings/memory-controllers/exynos5422-dmc.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> index e2434cac4858..02e4a1f862f1 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> @@ -55,7 +55,7 @@ Example:
>
> dmc: memory-controller@10c20000 {
> compatible = "samsung,exynos5422-dmc";
> - reg = <0x10c20000 0x100>, <0x10c30000 0x100>,
> + reg = <0x10c20000 0x10000>, <0x10c30000 0x10000>;
> clocks = <&clock CLK_FOUT_SPLL>,
> <&clock CLK_MOUT_SCLK_SPLL>,
> <&clock CLK_FF_DOUT_SPLL2>,
> @@ -63,7 +63,7 @@ Example:
> <&clock CLK_MOUT_BPLL>,
> <&clock CLK_SCLK_BPLL>,
> <&clock CLK_MOUT_MX_MSPLL_CCORE>,
> - <&clock CLK_MOUT_MCLK_CDREX>,
> + <&clock CLK_MOUT_MCLK_CDREX>;
> clock-names = "fout_spll",
> "mout_sclk_spll",
> "ff_dout_spll2",
> @@ -71,10 +71,10 @@ Example:
> "mout_bpll",
> "sclk_bpll",
> "mout_mx_mspll_ccore",
> - "mout_mclk_cdrex",
> + "mout_mclk_cdrex";
> operating-points-v2 = <&dmc_opp_table>;
> devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>,
> - <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>;
> + <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>;
> device-handle = <&samsung_K3QF2F20DB>;
> vdd-supply = <&buck1_reg>;
> samsung,syscon-clk = <&clock>;
>

Thank you for the patch. Indeed it must also be updated.

Reviewed-by: Lukasz Luba <[email protected]>

Regards,
Lukasz