2017-08-03 09:29:01

by Johannes Thumshirn

Subject: [PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it.

Signed-off-by: Johannes Thumshirn <[email protected]>
---
drivers/nvme/host/rdma.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index da04df1af231..57ac96ff9acb 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -36,8 +36,6 @@

#define NVME_RDMA_CONNECT_TIMEOUT_MS 3000 /* 3 second */

-#define NVME_RDMA_MAX_SEGMENT_SIZE 0xffffff /* 24-bit SGL field */
-
#define NVME_RDMA_MAX_SEGMENTS 256

#define NVME_RDMA_MAX_INLINE_SEGMENTS 1
--
2.12.3

2017-08-03 09:29:03

by Johannes Thumshirn

Subject: [PATCH 2/2] nvmet: fcloop: remove ALL_OPTS define

ALL_OPTS isn't used anywhere, remove it.

Signed-off-by: Johannes Thumshirn <[email protected]>
---
drivers/nvme/target/fcloop.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
index 1bb9d5b311b1..1cb9847ec261 100644
--- a/drivers/nvme/target/fcloop.c
+++ b/drivers/nvme/target/fcloop.c
@@ -193,9 +193,6 @@ fcloop_parse_nm_options(struct device *dev, u64 *nname, u64 *pname,

#define TGTPORT_OPTS (NVMF_OPT_WWNN | NVMF_OPT_WWPN)

-#define ALL_OPTS (NVMF_OPT_WWNN | NVMF_OPT_WWPN | NVMF_OPT_ROLES | \
- NVMF_OPT_FCADDR | NVMF_OPT_LPWWNN | NVMF_OPT_LPWWPN)
-

static DEFINE_SPINLOCK(fcloop_lock);
static LIST_HEAD(fcloop_lports);
--
2.12.3

2017-08-03 14:08:48

by Max Gurtovoy

Subject: Re: [PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

On 8/3/2017 12:28 PM, Johannes Thumshirn wrote:
> NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it.
>
> Signed-off-by: Johannes Thumshirn <[email protected]>
> ---

Looks good,

Reviewed-by: Max Gurtovoy <[email protected]>

2017-08-10 08:42:54

by Christoph Hellwig

Subject: Re: [PATCH 2/2] nvmet: fcloop: remove ALL_OPTS define

Thanks, applied both patches to nvme-4.14.