2020-04-20 15:13:14

by Prarit Bhargava

Subject: [PATCH] intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

On CLX-N, the perf-profile-level's output is terminated before the
speed-select-base-freq-properties are output which results in a corrupt
json file.

Adjust the output of speed-select-base-freq-properties by one on CLX-N.

Signed-off-by: Prarit Bhargava <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Cc: [email protected]
---
tools/power/x86/intel-speed-select/isst-display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c
index 51dbaa5f02ec..f6e2ce181123 100644
--- a/tools/power/x86/intel-speed-select/isst-display.c
+++ b/tools/power/x86/intel-speed-select/isst-display.c
@@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
_isst_pbf_display_information(cpu, outf,
tdp_level,
&ctdp_level->pbf_info,
- level + 1);
+ level + 2);
continue;
}

--
2.18.2

2020-04-20 15:46:15

by Andy Shevchenko

Subject: Re: [PATCH] intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

On Mon, Apr 20, 2020 at 6:11 PM Prarit Bhargava <[email protected]> wrote:
>
> On CLX-N, the perf-profile-level's output is terminated before the
> speed-select-base-freq-properties are output which results in a corrupt
> json file.
>
> Adjust the output of speed-select-base-freq-properties by one on CLX-N.
>

Thanks for the patch, it will be pulled from Srinivas' tree whenever
he sends a PR to PDx86 mailing list.


> Signed-off-by: Prarit Bhargava <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: [email protected]
> ---
> tools/power/x86/intel-speed-select/isst-display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c
> index 51dbaa5f02ec..f6e2ce181123 100644
> --- a/tools/power/x86/intel-speed-select/isst-display.c
> +++ b/tools/power/x86/intel-speed-select/isst-display.c
> @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
> _isst_pbf_display_information(cpu, outf,
> tdp_level,
> &ctdp_level->pbf_info,
> - level + 1);
> + level + 2);
> continue;
> }
>
> --
> 2.18.2
>


--
With Best Regards,
Andy Shevchenko

2020-04-20 16:41:53

by Prarit Bhargava

Subject: Re: [PATCH] intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

On 4/20/20 11:43 AM, Andy Shevchenko wrote:
> On Mon, Apr 20, 2020 at 6:11 PM Prarit Bhargava <[email protected]> wrote:
>>
>> On CLX-N, the perf-profile-level's output is terminated before the
>> speed-select-base-freq-properties are output which results in a corrupt
>> json file.
>>
>> Adjust the output of speed-select-base-freq-properties by one on CLX-N.
>>
>
> Thanks for the patch, it will be pulled from Srinivas' tree whenever
> he sends a PR to PDx86 mailing list.

Srinivas, OOC do you want these patches to be sent somewhere else? FWIW, I'm
running get_maintainers.pl to get the mailing list and cc.

P.

>
>
>> Signed-off-by: Prarit Bhargava <[email protected]>
>> Cc: Srinivas Pandruvada <[email protected]>
>> Cc: [email protected]
>> ---
>> tools/power/x86/intel-speed-select/isst-display.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c
>> index 51dbaa5f02ec..f6e2ce181123 100644
>> --- a/tools/power/x86/intel-speed-select/isst-display.c
>> +++ b/tools/power/x86/intel-speed-select/isst-display.c
>> @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
>> _isst_pbf_display_information(cpu, outf,
>> tdp_level,
>> &ctdp_level->pbf_info,
>> - level + 1);
>> + level + 2);
>> continue;
>> }
>>
>> --
>> 2.18.2
>>
>
>

2020-04-20 16:57:39

by srinivas pandruvada

Subject: Re: [PATCH] intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

On Mon, 2020-04-20 at 11:46 -0400, Prarit Bhargava wrote:
>
> On 4/20/20 11:43 AM, Andy Shevchenko wrote:
> > On Mon, Apr 20, 2020 at 6:11 PM Prarit Bhargava <[email protected]>
> > wrote:
> > > On CLX-N, the perf-profile-level's output is terminated before
> > > the
> > > speed-select-base-freq-properties are output which results in a
> > > corrupt
> > > json file.
> > >
> > > Adjust the output of speed-select-base-freq-properties by one on
> > > CLX-N.
> > >
> >
> > Thanks for the patch, it will be pulled from Srinivas' tree
> > whenever
> > he sends a PR to PDx86 mailing list.
>
> Srinivas, OOC do you want these patches to be sent somewhere
> else? FWIW, I'm
> running get_maintainers.pl to get the mailing list and cc.
This mailing list is fine.

I will take care of it once I test it out an apply to my tree.

Thanks,
Srinivas

>
> P.
>
> >
> > > Signed-off-by: Prarit Bhargava <[email protected]>
> > > Cc: Srinivas Pandruvada <[email protected]>
> > > Cc: [email protected]
> > > ---
> > > tools/power/x86/intel-speed-select/isst-display.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/power/x86/intel-speed-select/isst-display.c
> > > b/tools/power/x86/intel-speed-select/isst-display.c
> > > index 51dbaa5f02ec..f6e2ce181123 100644
> > > --- a/tools/power/x86/intel-speed-select/isst-display.c
> > > +++ b/tools/power/x86/intel-speed-select/isst-display.c
> > > @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu,
> > > FILE *outf, int tdp_level,
> > > _isst_pbf_display_information(cpu
> > > , outf,
> > > tdp
> > > _level,
> > > &ctdp_l
> > > evel->pbf_info,
> > > - lev
> > > el + 1);
> > > + lev
> > > el + 2);
> > > continue;
> > > }
> > >
> > > --
> > > 2.18.2
> > >

2020-04-22 00:24:28

by srinivas pandruvada

Subject: Re: [PATCH] intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

On Mon, 2020-04-20 at 10:10 -0400, Prarit Bhargava wrote:
> On CLX-N, the perf-profile-level's output is terminated before the
> speed-select-base-freq-properties are output which results in a
> corrupt
> json file.
>
> Adjust the output of speed-select-base-freq-properties by one on CLX-
> N.
Applied.

Thanks,
Srinivas

>
> Signed-off-by: Prarit Bhargava <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: [email protected]
> ---
> tools/power/x86/intel-speed-select/isst-display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-display.c
> b/tools/power/x86/intel-speed-select/isst-display.c
> index 51dbaa5f02ec..f6e2ce181123 100644
> --- a/tools/power/x86/intel-speed-select/isst-display.c
> +++ b/tools/power/x86/intel-speed-select/isst-display.c
> @@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE
> *outf, int tdp_level,
> _isst_pbf_display_information(cpu,
> outf,
> tdp_level
> ,
> &ctdp_level-
> >pbf_info,
> - level +
> 1);
> + level +
> 2);
> continue;
> }
>