EMC1444 is compatible with EMC1404. Add it to device ID table.
Reviewed-by: David Thompson <[email protected]>
Signed-off-by: Shravan Kumar Ramani <[email protected]>
---
drivers/hwmon/emc1403.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index bdab47a..88f6a40 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -453,6 +453,7 @@ static const struct i2c_device_id emc1403_idtable[] = {
{ "emc1422", emc1402 },
{ "emc1423", emc1403 },
{ "emc1424", emc1404 },
+ { "emc1444", emc1404 },
{ }
};
MODULE_DEVICE_TABLE(i2c, emc1403_idtable);
--
2.1.2
On Tue, Feb 26, 2019 at 10:40:05AM -0500, Shravan Kumar Ramani wrote:
> EMC1444 is compatible with EMC1404. Add it to device ID table.
>
Is that some super-secretive chip ? The Microchip website completely fails
to provide information about it. It lists a chip with that name under
"Microcontrollers and Processors", but with no documentation whatsoever.
And it seems like similar secretive chips such as emc1442 may exist as well.
I am hesitant to approve this without datasheet. The chips in this series
have a lot of registers, and I don't really trust the vendor to be
consistent across chip generations - even more so if they think that
they need to keep datasheets (and even basic information about the chip)
under wrap.
Until more information is available, I would suggest to instantiate
the chip as emc1424.
Guenter
> Reviewed-by: David Thompson <[email protected]>
> Signed-off-by: Shravan Kumar Ramani <[email protected]>
> ---
> drivers/hwmon/emc1403.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index bdab47a..88f6a40 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -453,6 +453,7 @@ static const struct i2c_device_id emc1403_idtable[] = {
> { "emc1422", emc1402 },
> { "emc1423", emc1403 },
> { "emc1424", emc1404 },
> + { "emc1444", emc1404 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, emc1403_idtable);
> --
> 2.1.2
>