2023-11-28 05:33:34

by Ricky Wu

[permalink] [raw]
Subject: [PATCH v5 0/3] Support new card reader rts5264

Summary
=======
This series adds support new card reader rts5264
rts5264 can support sd express card
new definitions and functions define in new file rts5264.h rts5264.c

Patch structure
===============
v4->v5:
add summary for this series

v3->v4:
split new definition part up from same patch

v2->v3:
split misc part and mmc part

v1->v2:
remove ic version check for rts5264

Ricky Wu(3):
misc: rtsx: add to support new card reader rts5264 new
definition and function
misc: rtsx: add to support new card reader rts5264
mmc: rtsx: add rts5264 to support sd express card

drivers/misc/cardreader/Makefile | 2 +-
drivers/misc/cardreader/rts5264.c | 886 +++++++++++++++++++++++++++++
drivers/misc/cardreader/rts5264.h | 278 +++++++++
drivers/misc/cardreader/rtsx_pcr.c | 30 +-
drivers/misc/cardreader/rtsx_pcr.h | 1 +
drivers/mmc/host/rtsx_pci_sdmmc.c | 17 +-
include/linux/rtsx_pci.h | 8 +
7 files changed, 1215 insertions(+), 7 deletions(-)
create mode 100644 drivers/misc/cardreader/rts5264.c
create mode 100644 drivers/misc/cardreader/rts5264.h


--
2.25.1


2023-11-28 07:41:35

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v5 0/3] Support new card reader rts5264

On Tue, Nov 28, 2023 at 05:32:47AM +0000, Ricky WU wrote:
> Summary
> =======
> This series adds support new card reader rts5264
> rts5264 can support sd express card
> new definitions and functions define in new file rts5264.h rts5264.c
>
> Patch structure
> ===============
> v4->v5:
> add summary for this series

That is not what I asked for here. Please make the changelog text for
the individual patches MUCH better. Perhaps work with one of your
coworkers to come up with some more text that properly describes what
the change is doing? Did you read the documentation link that I pointed
you at that should answer how to do this better?

Also, your patches are NOT properly linked together (look at them on
lore.kernel.org for proof), please use something like git send-email to
have them be linked so that we can apply them properly at the same time
together once they are ready.

thanks,

greg k-h