2022-03-29 02:04:33

by Howard Chiu

Subject: [PATCH v3 2/2] ARM: dts: aspeed: ast2600-evb: Support KVM

Enable video engine and reserve memory for it.
Enable USB for HID support

Signed-off-by: Howard Chiu <[email protected]>
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 39 +++++++++++++++++++-----
1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index b7eb552640cb..d535a711bf5a 100644
--- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
@@ -23,6 +23,19 @@ memory@80000000 {
reg = <0x80000000 0x80000000>;
};

+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ video_engine_memory: video {
+ size = <0x04000000>;
+ alignment = <0x01000000>;
+ compatible = "shared-dma-pool";
+ reusable;
+ };
+ };
+
vcc_sdhci0: regulator-vcc-sdhci0 {
compatible = "regulator-fixed";
regulator-name = "SDHCI0 Vcc";
@@ -250,14 +263,6 @@ &fsim0 {
status = "okay";
};

-&ehci1 {
- status = "okay";
-};
-
-&uhci {
- status = "okay";
-};
-
&sdc {
status = "okay";
};
@@ -300,3 +305,21 @@ &sdhci1 {
vqmmc-supply = <&vccq_sdhci1>;
clk-phase-sd-hs = <7>, <200>;
};
+
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
+
+&vhub {
+ status = "okay";
+ pinctrl-names = "default";
+};
+
+&video {
+ status = "okay";
+ memory-region = <&video_engine_memory>;
+};
--
2.25.1

2022-03-29 11:33:11

by Andrew Jeffery

Subject: Re: [PATCH v3 2/2] ARM: dts: aspeed: ast2600-evb: Support KVM

Hi Howard,

On Tue, 29 Mar 2022, at 12:08, Howard Chiu wrote:
> Enable video engine and reserve memory for it.
> Enable USB for HID support

These should be two separate patches. They're unrelated in the sense
that the video engine is separate from USB (even if your overall goal
is to enable KVM).

>
> Signed-off-by: Howard Chiu <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 39 +++++++++++++++++++-----
> 1 file changed, 31 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> index b7eb552640cb..d535a711bf5a 100644
> --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> @@ -23,6 +23,19 @@ memory@80000000 {
> reg = <0x80000000 0x80000000>;
> };
>
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> + };
> +
> vcc_sdhci0: regulator-vcc-sdhci0 {
> compatible = "regulator-fixed";
> regulator-name = "SDHCI0 Vcc";
> @@ -250,14 +263,6 @@ &fsim0 {
> status = "okay";
> };
>
> -&ehci1 {
> - status = "okay";
> -};
> -
> -&uhci {
> - status = "okay";
> -};
> -
> &sdc {
> status = "okay";
> };
> @@ -300,3 +305,21 @@ &sdhci1 {
> vqmmc-supply = <&vccq_sdhci1>;
> clk-phase-sd-hs = <7>, <200>;
> };
> +
> +&ehci1 {
> + status = "okay";
> +};
> +
> +&uhci {
> + status = "okay";
> +};

This movement of the ehci1 and uhci nodes seems unnecessary?

Andrew