IPQ5321 SoC belong to IPQ5332 family. Add the SoC ID and the cpufreq
support. Maximum cpufreq for IPQ5321 is 1.1GHZ, which is determined
based on the eFuse.
Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
---
Kathiravan Thirumoorthy (3):
dt-bindings: arm: qcom,ids: Add SoC ID for IPQ5321
soc: qcom: socinfo: Add SoC ID for IPQ5321
cpufreq: qcom-nvmem: add support for IPQ5321
drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
drivers/soc/qcom/socinfo.c | 1 +
include/dt-bindings/arm/qcom,ids.h | 1 +
3 files changed, 3 insertions(+)
---
base-commit: 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e
change-id: 20240228-ipq5321-sku-support-bd07056d5e01
Best regards,
--
Kathiravan Thirumoorthy <[email protected]>
Add the SoC ID for IPQ5321, which belong to the family of IPQ5332 SoC.
Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
---
drivers/soc/qcom/socinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index e8ff9819ac47..c6063fd293d0 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -443,6 +443,7 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(QCS8550) },
{ qcom_board_id(QCM8550) },
{ qcom_board_id(IPQ5300) },
+ { qcom_board_id(IPQ5321) },
};
static const char *socinfo_machine(struct device *dev, unsigned int id)
--
2.34.1
Add the ID for the Qualcomm IPQ5321 SoC.
Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
---
include/dt-bindings/arm/qcom,ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 19ac7b36f608..4563b1fb7a3b 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -271,6 +271,7 @@
#define QCOM_ID_QCS8550 603
#define QCOM_ID_QCM8550 604
#define QCOM_ID_IPQ5300 624
+#define QCOM_ID_IPQ5321 650
/*
* The board type and revision information, used by Qualcomm bootloaders and
--
2.34.1
On 2/28/2024 8:21 PM, Kathiravan Thirumoorthy wrote:
> IPQ5321 SoC belong to IPQ5332 family. Add the SoC ID and the cpufreq
> support. Maximum cpufreq for IPQ5321 is 1.1GHZ, which is determined
> based on the eFuse.
>
> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
for the series..
-Mukesh
> ---
> Kathiravan Thirumoorthy (3):
> dt-bindings: arm: qcom,ids: Add SoC ID for IPQ5321
> soc: qcom: socinfo: Add SoC ID for IPQ5321
> cpufreq: qcom-nvmem: add support for IPQ5321
>
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
> drivers/soc/qcom/socinfo.c | 1 +
> include/dt-bindings/arm/qcom,ids.h | 1 +
> 3 files changed, 3 insertions(+)
> ---
> base-commit: 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e
> change-id: 20240228-ipq5321-sku-support-bd07056d5e01
>
> Best regards,
Like all other SoCs in IPQ5332 family, cpufreq for IPQ5321 is also
determined by the eFuse, with the maximum limit of 1.1GHz. Add support
for the same.
Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
---
drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
index ea05d9d67490..0a46b5d49d32 100644
--- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
+++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
@@ -191,6 +191,7 @@ static int qcom_cpufreq_kryo_name_version(struct device *cpu_dev,
case QCOM_ID_IPQ5312:
case QCOM_ID_IPQ5302:
case QCOM_ID_IPQ5300:
+ case QCOM_ID_IPQ5321:
case QCOM_ID_IPQ9514:
case QCOM_ID_IPQ9550:
case QCOM_ID_IPQ9554:
--
2.34.1
On 28/02/2024 15:51, Kathiravan Thirumoorthy wrote:
> Add the ID for the Qualcomm IPQ5321 SoC.
>
> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
> ---
> include/dt-bindings/arm/qcom,ids.h | 1 +
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 28/02/2024 15:51, Kathiravan Thirumoorthy wrote:
> Add the SoC ID for IPQ5321, which belong to the family of IPQ5332 SoC.
>
> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 28-02-24, 20:21, Kathiravan Thirumoorthy wrote:
> Like all other SoCs in IPQ5332 family, cpufreq for IPQ5321 is also
> determined by the eFuse, with the maximum limit of 1.1GHz. Add support
> for the same.
>
> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
> ---
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index ea05d9d67490..0a46b5d49d32 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -191,6 +191,7 @@ static int qcom_cpufreq_kryo_name_version(struct device *cpu_dev,
> case QCOM_ID_IPQ5312:
> case QCOM_ID_IPQ5302:
> case QCOM_ID_IPQ5300:
> + case QCOM_ID_IPQ5321:
> case QCOM_ID_IPQ9514:
> case QCOM_ID_IPQ9550:
> case QCOM_ID_IPQ9554:
Applied. Thanks.
--
viresh
On 04-03-24, 12:42, Viresh Kumar wrote:
> On 28-02-24, 20:21, Kathiravan Thirumoorthy wrote:
> > Like all other SoCs in IPQ5332 family, cpufreq for IPQ5321 is also
> > determined by the eFuse, with the maximum limit of 1.1GHz. Add support
> > for the same.
> >
> > Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
> > ---
> > drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> > index ea05d9d67490..0a46b5d49d32 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> > @@ -191,6 +191,7 @@ static int qcom_cpufreq_kryo_name_version(struct device *cpu_dev,
> > case QCOM_ID_IPQ5312:
> > case QCOM_ID_IPQ5302:
> > case QCOM_ID_IPQ5300:
> > + case QCOM_ID_IPQ5321:
> > case QCOM_ID_IPQ9514:
> > case QCOM_ID_IPQ9550:
> > case QCOM_ID_IPQ9554:
>
> Applied. Thanks.
Dropped since the previous commit it required too. Can we get the
necessary acks for me to pick those ?
--
viresh
On 3/5/2024 10:05 AM, Viresh Kumar wrote:
> On 04-03-24, 12:42, Viresh Kumar wrote:
>> On 28-02-24, 20:21, Kathiravan Thirumoorthy wrote:
>>> Like all other SoCs in IPQ5332 family, cpufreq for IPQ5321 is also
>>> determined by the eFuse, with the maximum limit of 1.1GHz. Add support
>>> for the same.
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
>>> ---
>>> drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
>>> index ea05d9d67490..0a46b5d49d32 100644
>>> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
>>> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
>>> @@ -191,6 +191,7 @@ static int qcom_cpufreq_kryo_name_version(struct device *cpu_dev,
>>> case QCOM_ID_IPQ5312:
>>> case QCOM_ID_IPQ5302:
>>> case QCOM_ID_IPQ5300:
>>> + case QCOM_ID_IPQ5321:
>>> case QCOM_ID_IPQ9514:
>>> case QCOM_ID_IPQ9550:
>>> case QCOM_ID_IPQ9554:
>>
>> Applied. Thanks.
>
> Dropped since the previous commit it required too. Can we get the
> necessary acks for me to pick those ?
>
Sorry for not mentioning the dependencies.
patch 1/3 and 2/3 are already has the R-b and A-b tags. But typically
those patches will go via qcom tree. Do you want to pick it via your
tree? Sorry, I'm not sure on this...
Thanks,
Kathiravan T.
Bjorn,
On 06-03-24, 10:10, Kathiravan Thirumoorthy wrote:
> patch 1/3 and 2/3 are already has the R-b and A-b tags. But typically those
> patches will go via qcom tree. Do you want to pick it via your tree? Sorry,
> I'm not sure on this...
Should I pick all the patches ?
--
viresh
On 06-03-24, 10:48, Viresh Kumar wrote:
> Bjorn,
>
> On 06-03-24, 10:10, Kathiravan Thirumoorthy wrote:
> > patch 1/3 and 2/3 are already has the R-b and A-b tags. But typically those
> > patches will go via qcom tree. Do you want to pick it via your tree? Sorry,
> > I'm not sure on this...
>
> Should I pick all the patches ?
Okay, there are conflicts for the first patch itself. Bjorn you can
apply all the patches.
For this patch:
Acked-by: Viresh Kumar <[email protected]>
--
viresh
On 06/03/2024 05:40, Kathiravan Thirumoorthy wrote:
>>>
>>> Applied. Thanks.
>>
>> Dropped since the previous commit it required too. Can we get the
>> necessary acks for me to pick those ?
>>
>
> Sorry for not mentioning the dependencies.
>
> patch 1/3 and 2/3 are already has the R-b and A-b tags. But typically
From whom? Not from Qualcomm SoC maintainers.
> those patches will go via qcom tree. Do you want to pick it via your
> tree? Sorry, I'm not sure on this...
Your cover letter or patch changelog should clearly document
dependencies, so maintainers could understand what to do with this patch.
Best regards,
Krzysztof
On 3/6/2024 12:52 PM, Krzysztof Kozlowski wrote:
> On 06/03/2024 05:40, Kathiravan Thirumoorthy wrote:
>>>>
>>>> Applied. Thanks.
>>>
>>> Dropped since the previous commit it required too. Can we get the
>>> necessary acks for me to pick those ?
>>>
>>
>> Sorry for not mentioning the dependencies.
>>
>> patch 1/3 and 2/3 are already has the R-b and A-b tags. But typically
>
> From whom? Not from Qualcomm SoC maintainers.
Does the "necessary acks" refers for to the acks from Qualcomm SoC
maintainers? Sorry, I wasn't aware of that. That's why I mentioned
"Sorry, I'm not sure on this..." couple of lines below.
>
>> those patches will go via qcom tree. Do you want to pick it via your
>> tree? Sorry, I'm not sure on this...
>
> Your cover letter or patch changelog should clearly document
> dependencies, so maintainers could understand what to do with this patch.
Understood. Will take care in future.
>
> Best regards,
> Krzysztof
>