2021-02-16 14:11:35

by Colin King

Subject: [PATCH] tracing/tools: fix a couple of spelling mistakes

From: Colin Ian King <[email protected]>

There is a spelling mistake in the -g help option, I believe
it should be "graph". There is also a spelling mistake in a
warning message. Fix both mistakes.

Signed-off-by: Colin Ian King <[email protected]>
---

V2: Also fix "nummer" spelling mistake.

---
tools/tracing/latency/latency-collector.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
index 57b20802e71b..bfe084bc460e 100644
--- a/tools/tracing/latency/latency-collector.c
+++ b/tools/tracing/latency/latency-collector.c
@@ -1650,7 +1650,7 @@ static void start_printthread(void)
if (ufd < 0 ||
read(ufd, seed, sizeof(*seed)) != sizeof(*seed)) {
printf(
-"Warning! Using trivial random nummer seed, since %s not available\n",
+"Warning! Using trivial random number seed, since %s not available\n",
DEV_URANDOM);
fflush(stdout);
*seed = i;
@@ -1711,7 +1711,7 @@ static void show_usage(void)
"\t\t\tbeginning, end, and backtrace.\n\n"

"-g, --graph\t\tEnable the display-graph option in trace_option. This\n"
-"\t\t\toption causes ftrace to show the functionph of how\n"
+"\t\t\toption causes ftrace to show the graph of how\n"
"\t\t\tfunctions are calling other functions.\n\n"

"-c, --policy POL\tRun the program with scheduling policy POL. POL can be\n"
--
2.30.0

2021-02-16 15:21:52

by Viktor Rosendahl

Subject: Re: [PATCH] tracing/tools: fix a couple of spelling mistakes

Hi,

Thanks for finding these mistakes.

On Tue, 2021-02-16 at 14:08 +0000, Colin King wrote:

> printf(
> -"Warning! Using trivial random nummer seed, since %s not available\n",
> +"Warning! Using trivial random number seed, since %s not available\n",
> DEV_URANDOM);
> fflush(stdout);
> *seed = i;
> @@ -1711,7 +1711,7 @@ static void show_usage(void)
> "\t\t\tbeginning, end, and backtrace.\n\n"
>
> "-g, --graph\t\tEnable the display-graph option in trace_option. This\n"
> -"\t\t\toption causes ftrace to show the functionph of how\n"
> +"\t\t\toption causes ftrace to show the graph of how\n"
> "\t\t\tfunctions are calling other functions.\n\n"

This is a large improvement but since the corrected word is so much shorter, we
would ideally move the first word of the next line to this line as well:

"\t\t\toption causes ftrace to show the graph of how functions\n"
"\t\t\tare calling other functions.\n\n"

best regards,

Viktor

>
> "-c, --policy POL\tRun the program with scheduling policy POL. POL can be\n"