2022-03-04 15:39:54

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH v2 01/20] ASoC: cs35l41: Fix GPIO2 configuration

On Fri, Mar 04, 2022 at 03:07:02PM +0000, Lucas Tanure wrote:
> From: David Rhodes <[email protected]>
>
> Fix GPIO2 polarity and direction configuration
>
> Fixes: fe1024d50477b ("ASoC: cs35l41: Combine adjacent register writes")
> Signed-off-by: David Rhodes <[email protected]>
> Acked-by: Charles Keepax <[email protected]>
> ---

Really sorry I only just spotted this but you are missing your
own sign off here. You always need to personally sign each patch
you are sending up.

Thanks,
Charles


2022-03-04 19:10:06

by Lucas Tanure

[permalink] [raw]
Subject: Re: [PATCH v2 01/20] ASoC: cs35l41: Fix GPIO2 configuration

On 3/4/22 3:22 PM, Charles Keepax <[email protected]> wrote:
> On Fri, Mar 04, 2022 at 03:07:02PM +0000, Lucas Tanure wrote:
> > From: David Rhodes <[email protected]>
> >
> > Fix GPIO2 polarity and direction configuration
> >
> > Fixes: fe1024d50477b ("ASoC: cs35l41: Combine adjacent register writes")
> > Signed-off-by: David Rhodes <[email protected]>
> > Acked-by: Charles Keepax <[email protected]>
> > ---
>
> Really sorry I only just spotted this but you are missing your
> own sign off here. You always need to personally sign each patch
> you are sending up.
>
> Thanks,
> Charles
>
Yes, sorry about that. I will give some time for more reviews on this version and fix it on v3.