2023-07-25 16:43:55

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB

The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
user about this driver when configuring a kernel without Broadcom
ARM-based set-top box chipset support.

Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index d4166141145d631c..75ca3ddda1f5e09f 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -257,6 +257,7 @@ config BNXT_HWMON

config BCMASP
tristate "Broadcom ASP 2.0 Ethernet support"
+ depends on ARCH_BRCMSTB || COMPILE_TEST
default ARCH_BRCMSTB
depends on OF
select MII
--
2.34.1



2023-07-25 17:06:15

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB

On Tue, Jul 25, 2023 at 05:46:37PM +0200, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
>
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2023-07-25 21:25:38

by Justin Chen

[permalink] [raw]
Subject: Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB



On 7/25/23 8:46 AM, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
>
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Justin Chen <[email protected]>

> ---
> drivers/net/ethernet/broadcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index d4166141145d631c..75ca3ddda1f5e09f 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -257,6 +257,7 @@ config BNXT_HWMON
>
> config BCMASP
> tristate "Broadcom ASP 2.0 Ethernet support"
> + depends on ARCH_BRCMSTB || COMPILE_TEST
> default ARCH_BRCMSTB
> depends on OF
> select MII

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2023-07-27 05:28:20

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 25 Jul 2023 17:46:37 +0200 you wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
>
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> [...]

Here is the summary with links:
- [net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
https://git.kernel.org/netdev/net-next/c/73365fe44aa5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html