2017-11-20 10:30:18

by Lars Melin

[permalink] [raw]
Subject: Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819

On 11/20/2017 16:27, Shrirang Bagul wrote:
> Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74
> series modems which will by default boot with vid 0x413c and pid's
> 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support
> qmi_wwan on the usb interface #12.
>
> Signed-off-by: Shrirang Bagul <[email protected]>
> ---
> drivers/net/usb/qmi_wwan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 8d4a6f7cba61..bdf1fae38af2 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1234,6 +1234,10 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x413c, 0x81b3, 8)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> {QMI_FIXED_INTF(0x413c, 0x81b6, 8)}, /* Dell Wireless 5811e */
> {QMI_FIXED_INTF(0x413c, 0x81b6, 10)}, /* Dell Wireless 5811e */
> + {QMI_FIXED_INTF(0x413c, 0x81cf, 12)}, /* Dell Wireless 5819 */
> + {QMI_FIXED_INTF(0x413c, 0x81d0, 12)}, /* Dell Wireless 5819 */
> + {QMI_FIXED_INTF(0x413c, 0x81d1, 12)}, /* Dell Wireless 5818 */
> + {QMI_FIXED_INTF(0x413c, 0x81d2, 12)}, /* Dell Wireless 5818 */
> {QMI_FIXED_INTF(0x03f0, 0x4e1d, 8)}, /* HP lt4111 LTE/EV-DO/HSPA+ Gobi 4G Module */
> {QMI_FIXED_INTF(0x22de, 0x9061, 3)}, /* WeTelecom WPD-600N */
> {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */
>


NAK

413c:81cf and 413c:81d1 do not have a net interface, they only have a
single serial interface (QDL) for firmware update.
Please do not add usb id's for which you have not confirmed the
interface composition.

br
Lars


From 1584578829832287764@xxx Mon Nov 20 10:02:12 +0000 2017
X-GM-THRID: 1584576858470207274
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread