2018-04-25 08:36:47

by Yisheng Xie

Subject: [PATCH] perf bench numa: Fixes typo in options

'R' means access the data via reads instead of writes, fix this typo.

Signed-off-by: Yisheng Xie <[email protected]>
---
tools/perf/bench/numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
index 944070e..63eb4908 100644
--- a/tools/perf/bench/numa.c
+++ b/tools/perf/bench/numa.c
@@ -175,7 +175,7 @@ struct global_info {
OPT_UINTEGER('s', "nr_secs" , &p0.nr_secs, "max number of seconds to run (default: 5 secs)"),
OPT_UINTEGER('u', "usleep" , &p0.sleep_usecs, "usecs to sleep per loop iteration"),

- OPT_BOOLEAN('R', "data_reads" , &p0.data_reads, "access the data via writes (can be mixed with -W)"),
+ OPT_BOOLEAN('R', "data_reads" , &p0.data_reads, "access the data via reads (can be mixed with -W)"),
OPT_BOOLEAN('W', "data_writes" , &p0.data_writes, "access the data via writes (can be mixed with -R)"),
OPT_BOOLEAN('B', "data_backwards", &p0.data_backwards, "access the data backwards as well"),
OPT_BOOLEAN('Z', "data_zero_memset", &p0.data_zero_memset,"access the data via glibc bzero only"),
--
1.7.12.4

2018-05-07 10:47:13

by Yisheng Xie

Subject: Re: [PATCH] perf bench numa: Fixes typo in options

Hi Arnaldo,

Just in case that you may miss this minor fix.

Thanks
Yisheng

On 2018/4/25 16:25, Yisheng Xie wrote:
> 'R' means access the data via reads instead of writes, fix this typo.
>
> Signed-off-by: Yisheng Xie <[email protected]>
> ---
> tools/perf/bench/numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
> index 944070e..63eb4908 100644
> --- a/tools/perf/bench/numa.c
> +++ b/tools/perf/bench/numa.c
> @@ -175,7 +175,7 @@ struct global_info {
> OPT_UINTEGER('s', "nr_secs" , &p0.nr_secs, "max number of seconds to run (default: 5 secs)"),
> OPT_UINTEGER('u', "usleep" , &p0.sleep_usecs, "usecs to sleep per loop iteration"),
>
> - OPT_BOOLEAN('R', "data_reads" , &p0.data_reads, "access the data via writes (can be mixed with -W)"),
> + OPT_BOOLEAN('R', "data_reads" , &p0.data_reads, "access the data via reads (can be mixed with -W)"),
> OPT_BOOLEAN('W', "data_writes" , &p0.data_writes, "access the data via writes (can be mixed with -R)"),
> OPT_BOOLEAN('B', "data_backwards", &p0.data_backwards, "access the data backwards as well"),
> OPT_BOOLEAN('Z', "data_zero_memset", &p0.data_zero_memset,"access the data via glibc bzero only"),
>

2018-05-07 15:09:09

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf bench numa: Fixes typo in options

Em Mon, May 07, 2018 at 06:45:31PM +0800, Yisheng Xie escreveu:
> Hi Arnaldo,
>
> Just in case that you may miss this minor fix.
>
> Thanks
> Yisheng

Thanks, applied to my perf/core branch.

- Arnaldo

2018-05-10 18:15:21

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf bench numa: Fix typo in options

Commit-ID: 2abb80dad3afa9170ae19ca03bb7b4cd1ec06d62
Gitweb: https://git.kernel.org/tip/2abb80dad3afa9170ae19ca03bb7b4cd1ec06d62
Author: Yisheng Xie <[email protected]>
AuthorDate: Wed, 25 Apr 2018 16:25:07 +0800
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 7 May 2018 12:17:56 -0300

perf bench numa: Fix typo in options

'R' means access the data via reads instead of writes, fix this typo.

Signed-off-by: Yisheng Xie <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/bench/numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
index 944070e98a2c..63eb49082774 100644
--- a/tools/perf/bench/numa.c
+++ b/tools/perf/bench/numa.c
@@ -175,7 +175,7 @@ static const struct option options[] = {
OPT_UINTEGER('s', "nr_secs" , &p0.nr_secs, "max number of seconds to run (default: 5 secs)"),
OPT_UINTEGER('u', "usleep" , &p0.sleep_usecs, "usecs to sleep per loop iteration"),

- OPT_BOOLEAN('R', "data_reads" , &p0.data_reads, "access the data via writes (can be mixed with -W)"),
+ OPT_BOOLEAN('R', "data_reads" , &p0.data_reads, "access the data via reads (can be mixed with -W)"),
OPT_BOOLEAN('W', "data_writes" , &p0.data_writes, "access the data via writes (can be mixed with -R)"),
OPT_BOOLEAN('B', "data_backwards", &p0.data_backwards, "access the data backwards as well"),
OPT_BOOLEAN('Z', "data_zero_memset", &p0.data_zero_memset,"access the data via glibc bzero only"),