2024-05-03 15:44:56

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage

Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
handheld gaming device variants") mistakenly added '-' on each line
which created empty (i.e. description only) schemas matching anything.
This causes validation to fail on all the root node compatibles as
there are multiple oneOf clauses passing.

Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants")
Signed-off-by: Rob Herring (Arm) <[email protected]>
---
Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index c6d0d8d81ed4..c2a158b75e49 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -57,17 +57,17 @@ properties:
- const: allwinner,sun8i-v3s

- description: Anbernic RG35XX (2024)
- - items:
+ items:
- const: anbernic,rg35xx-2024
- const: allwinner,sun50i-h700

- description: Anbernic RG35XX Plus
- - items:
+ items:
- const: anbernic,rg35xx-plus
- const: allwinner,sun50i-h700

- description: Anbernic RG35XX H
- - items:
+ items:
- const: anbernic,rg35xx-h
- const: allwinner,sun50i-h700

--
2.43.0

2024-05-03 17:02:08

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage

On 03/05/2024 17:44, Rob Herring (Arm) wrote:
> Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants") mistakenly added '-' on each line
> which created empty (i.e. description only) schemas matching anything.
> This causes validation to fail on all the root node compatibles as
> there are multiple oneOf clauses passing.
>
> Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants")
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-05-11 08:16:24

by Ryan Walklin

Subject: Re: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage

On Sat, 4 May 2024, at 3:44 AM, Rob Herring (Arm) wrote:
> Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants") mistakenly added '-' on each line
> which created empty (i.e. description only) schemas matching anything.
> This causes validation to fail on all the root node compatibles as
> there are multiple oneOf clauses passing.
>
> Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants")
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---
Apologies, thanks for the fix.

Reviewed-by: Ryan Walklin <[email protected]>

Regards,

Ryan

2024-05-28 21:19:17

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage

On Fri, 03 May 2024 10:44:02 -0500, Rob Herring (Arm) wrote:
> Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants") mistakenly added '-' on each line
> which created empty (i.e. description only) schemas matching anything.
> This causes validation to fail on all the root node compatibles as
> there are multiple oneOf clauses passing.
>
> Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants")
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

No one has picked this up yet, so I have. Applied, thanks!