2021-03-19 01:28:39

by Bhaskar Chowdhury

[permalink] [raw]
Subject: [PATCH] blk-mq: Trivial typo fix

s/funtion/function/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
block/blk-mq-tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..ad91e98dbc43 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -374,7 +374,7 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,

/**
* blk_mq_tagset_wait_completed_request - wait until all completed req's
- * complete funtion is run
+ * complete function is run
* @tagset: Tag set to drain completed request
*
* Note: This function has to be run after all IO queues are shutdown
--
2.26.2


2021-03-19 18:01:48

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] blk-mq: Trivial typo fix



On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:

> s/funtion/function/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

The change is correct, but it doesn't help me when I try to read
that function description. :(

Acked-by: Randy Dunlap <[email protected]>

> ---
> block/blk-mq-tag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 9c92053e704d..ad91e98dbc43 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -374,7 +374,7 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>
> /**
> * blk_mq_tagset_wait_completed_request - wait until all completed req's
> - * complete funtion is run
> + * complete function is run
> * @tagset: Tag set to drain completed request
> *
> * Note: This function has to be run after all IO queues are shutdown
> --
> 2.26.2
>
>

2021-03-19 19:52:47

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] blk-mq: Trivial typo fix

On 10:58 Fri 19 Mar 2021, Randy Dunlap wrote:
>
>
>On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
>> s/funtion/function/
>>
>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>
>The change is correct, but it doesn't help me when I try to read
>that function description. :(
>
I have reconstructed that sentence for better readability and send a V2 for
your perusal.Changes the subject line accordingly too.

>Acked-by: Randy Dunlap <[email protected]>
>
>> ---
>> block/blk-mq-tag.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
>> index 9c92053e704d..ad91e98dbc43 100644
>> --- a/block/blk-mq-tag.c
>> +++ b/block/blk-mq-tag.c
>> @@ -374,7 +374,7 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>>
>> /**
>> * blk_mq_tagset_wait_completed_request - wait until all completed req's
>> - * complete funtion is run
>> + * complete function is run
>> * @tagset: Tag set to drain completed request
>> *
>> * Note: This function has to be run after all IO queues are shutdown
>> --
>> 2.26.2
>>
>>


Attachments:
(No filename) (1.11 kB)
signature.asc (499.00 B)
Download all attachments