The "swap-dx-lanes" was never described as uint8 in original TXT
bindings and Linux driver expects uint32. Fix the type to match Linux
driver expectation.
Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes in v2:
1. Correct commit msg typo (Marek)
Cc: [email protected]
Cc: [email protected]
---
Documentation/devicetree/bindings/usb/usb251xb.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml
index 4d1530816817..ac5b99710332 100644
--- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
+++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
@@ -231,7 +231,7 @@ properties:
power-on sequence to a port until the port has adequate power.
swap-dx-lanes:
- $ref: /schemas/types.yaml#/definitions/uint8-array
+ $ref: /schemas/types.yaml#/definitions/uint32-array
description: |
Specifies the ports which will swap the differential-pair (D+/D-),
default is not-swapped.
--
2.34.1
On 5/16/23 10:34, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linux driver expects uint32. Fix the type to match Linux
> driver expectation.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Marek Vasut <[email protected]>
Thanks
On Tue, May 16, 2023 at 10:34:32AM +0200, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linux driver expects uint32. Fix the type to match Linux
> driver expectation.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
LGTM. Please feel free to add
Reviewed-by: Richard Leitner <[email protected]>
On Tue, May 16, 2023 at 10:34:32AM +0200, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linux driver expects uint32. Fix the type to match Linux
> driver expectation.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Thanks,
Conor.