2024-01-08 18:19:52

by Breno Leitao

Subject: [PATCH net-next 04/10] net: fill in MODULE_DESCRIPTION()s for NFC

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to all NFC Controller Interface (NCI) modules.

Signed-off-by: Breno Leitao <[email protected]>
---
net/nfc/digital_core.c | 1 +
net/nfc/nci/core.c | 1 +
net/nfc/nci/spi.c | 1 +
3 files changed, 3 insertions(+)

diff --git a/net/nfc/digital_core.c b/net/nfc/digital_core.c
index d63d2e5dc60c..dae378f1d52b 100644
--- a/net/nfc/digital_core.c
+++ b/net/nfc/digital_core.c
@@ -858,4 +858,5 @@ void nfc_digital_unregister_device(struct nfc_digital_dev *ddev)
}
EXPORT_SYMBOL(nfc_digital_unregister_device);

+MODULE_DESCRIPTION("NFC Digital protocol stack");
MODULE_LICENSE("GPL");
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index 6c9592d05120..97348cedb16b 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -1577,4 +1577,5 @@ static void nci_cmd_work(struct work_struct *work)
}
}

+MODULE_DESCRIPTION("NFC Controller Interface");
MODULE_LICENSE("GPL");
diff --git a/net/nfc/nci/spi.c b/net/nfc/nci/spi.c
index b68150c971d0..6a93533c480e 100644
--- a/net/nfc/nci/spi.c
+++ b/net/nfc/nci/spi.c
@@ -319,4 +319,5 @@ struct sk_buff *nci_spi_read(struct nci_spi *nspi)
}
EXPORT_SYMBOL_GPL(nci_spi_read);

+MODULE_DESCRIPTION("NFC Controller Interface (NCI) SPI link layer");
MODULE_LICENSE("GPL");
--
2.39.3

2024-01-08 18:58:03

by Krzysztof Kozlowski

Subject: Re: [PATCH net-next 04/10] net: fill in MODULE_DESCRIPTION()s for NFC

On 08/01/2024 19:16, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to all NFC Controller Interface (NCI) modules.
>
> Signed-off-by: Breno Leitao <[email protected]>
> ---
> net/nfc/digital_core.c | 1 +
> net/nfc/nci/core.c | 1 +

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof