2023-04-24 09:48:37

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next][V3] rv: Fix addition on an uninitialized variable 'run'

The variable run is not initialized however it is being accumulated
by the return value from the call to ikm_run_monitor. Fix this by
initializing run to zero at the start of the function.

Fixes: 4bc4b131d44c ("rv: Add rv tool")

Signed-off-by: Colin Ian King <[email protected]>

---
V2: Initialize run rather than assign it from return from ikm_run_monitor
V3: Add missing V3 and next in patch subject
---
tools/verification/rv/src/rv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/verification/rv/src/rv.c b/tools/verification/rv/src/rv.c
index e601cd9c411e..1ddb85532816 100644
--- a/tools/verification/rv/src/rv.c
+++ b/tools/verification/rv/src/rv.c
@@ -74,7 +74,7 @@ static void rv_list(int argc, char **argv)
static void rv_mon(int argc, char **argv)
{
char *monitor_name;
- int i, run;
+ int i, run = 0;

static const char *const usage[] = {
"",
--
2.30.2


Subject: Re: [PATCH][next][V3] rv: Fix addition on an uninitialized variable 'run'

On 4/24/23 11:47, Colin Ian King wrote:
> The variable run is not initialized however it is being accumulated
> by the return value from the call to ikm_run_monitor. Fix this by
> initializing run to zero at the start of the function.
>
> Fixes: 4bc4b131d44c ("rv: Add rv tool")
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Daniel Bristot de Oliveira <[email protected]>

Thanks!
-- Daniel