2019-08-27 13:45:15

by Yue Haibing

Subject: [PATCH -next] btrfs: Make inc_block_group_ro static

Fix sparse warning:

fs/btrfs/block-group.c:1183:5: warning:
symbol 'inc_block_group_ro' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
fs/btrfs/block-group.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
index 3147e84..8cc7768 100644
--- a/fs/btrfs/block-group.c
+++ b/fs/btrfs/block-group.c
@@ -1180,7 +1180,7 @@ struct btrfs_trans_handle *btrfs_start_trans_remove_block_group(
* data in this block group. That check should be done by relocation routine,
* not this function.
*/
-int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
+static int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
{
struct btrfs_space_info *sinfo = cache->space_info;
u64 num_bytes;
--
2.7.4

2019-08-27 13:50:19

by Nikolay Borisov

Subject: Re: [PATCH -next] btrfs: Make inc_block_group_ro static

On 27.08.19 г. 16:43 ч., YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/block-group.c:1183:5: warning:
> symbol 'inc_block_group_ro' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Nikolay Borisov <[email protected]>

> ---
> fs/btrfs/block-group.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index 3147e84..8cc7768 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -1180,7 +1180,7 @@ struct btrfs_trans_handle *btrfs_start_trans_remove_block_group(
> * data in this block group. That check should be done by relocation routine,
> * not this function.
> */
> -int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
> +static int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
> {
> struct btrfs_space_info *sinfo = cache->space_info;
> u64 num_bytes;
>