On 8/3/23 3:00 PM, Zhu Wang wrote:
> When platform_get_irq_byname() failed, it may return -EPROBE_DEFER,
s/failed/fails/, I think...
> -EINVAL or -ENXIO, it is important to propagate the detail upstream, we
> cannot override it.
You better rename the patch to something like "usb: musb: Fix deferred
probing" now. And remove "-next:, as this became a real fix.
> And platform_get_irq_byname() used to return 0 (as both IRQ0 and error
> indication), there are several patches fixing the inconsistencies.
In no way I suggested to take my "historical" passage into the
patch description!
> Commit ce753ad1549c ("platform: finally disallow IRQ0 in
> platform_get_irq() and its ilk") makes sure IRQ0 is not returned.
>
> Signed-off-by: Zhu Wang <[email protected]>
>
> ---
> Changes in v2:
> - Update the commit message, present the reason of replacing the return
> value of the probe.
>
> ---
> Changes in v3:
> - Update the commit message, explain in detail why the return value of
> platform_get_irq_byname() cannot be override.
You didn't emphasize the deferred probing breakage we're trying to
fix here at last; the other error codes here are not very important...
[...]
MBR, Sergey