2023-01-13 04:14:44

by Bjorn Andersson

Subject: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp

With the transition of disabling unused clocks at sync_state, rather
than late_initcall() it's now possible to drop clk_ignore_unused and
unused clock disabled once client drivers have probed. Do this on
SC8280XP.

Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
drivers/clk/qcom/gcc-sc8280xp.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
index 167470beb369..c84a6481b879 100644
--- a/drivers/clk/qcom/dispcc-sc8280xp.c
+++ b/drivers/clk/qcom/dispcc-sc8280xp.c
@@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
.driver = {
.name = "disp_cc-sc8280xp",
.of_match_table = disp_cc_sc8280xp_match_table,
+ .sync_state = clk_sync_state_disable_unused,
},
};

diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
index b3198784e1c3..f4fdc5b9663c 100644
--- a/drivers/clk/qcom/gcc-sc8280xp.c
+++ b/drivers/clk/qcom/gcc-sc8280xp.c
@@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
.driver = {
.name = "gcc-sc8280xp",
.of_match_table = gcc_sc8280xp_match_table,
+ .sync_state = clk_sync_state_disable_unused,
},
};

--
2.37.3

2023-01-13 04:30:33

by Konrad Dybcio

Subject: Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp

The subject could be more in the likes of "use disable_unused sync_state"..

On 13.01.2023 05:10, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
Acked-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>

2023-01-13 20:34:55

by Andrew Halaney

Subject: Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp

On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Tested-by: Andrew Halaney <[email protected]> # sc8280xp-lenovo-thinkpad-x13s

I've booted with this (and without clk_ignore_unused) a few times today
and have been working with on the machine without any apparent issues.

Thanks! It is nice to have to modify less of the kernel cli to boot.

> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>

2023-01-15 04:16:00

by Manivannan Sadhasivam

Subject: Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp

On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>

--
மணிவண்ணன் சதாசிவம்

2023-01-15 16:22:39

by Abel Vesa

Subject: Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp

On 23-01-12 20:10:38, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>

2023-01-17 19:36:07

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp

On Thu, 12 Jan 2023 20:10:38 -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
>

Applied, thanks!

[1/1] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
commit: 29e31415e14e16e25d428205c7230400dea1d7cf

Best regards,
--
Bjorn Andersson <[email protected]>