2022-06-28 13:33:35

by Tom Lendacky

Subject: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
network device driver.

Cc: Shyam Sundar S K <[email protected]>
Signed-off-by: Tom Lendacky <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 36f0a205c54a..02e0d0464312 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1037,6 +1037,7 @@ F: arch/arm64/boot/dts/amd/

AMD XGBE DRIVER
M: Tom Lendacky <[email protected]>
+M: Shyam Sundar S K <[email protected]>
L: [email protected]
S: Supported
F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi
--
2.36.1

2022-06-28 17:55:57

by Joe Perches

Subject: Re: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
> network device driver.
>
> Cc: Shyam Sundar S K <[email protected]>
> Signed-off-by: Tom Lendacky <[email protected]>
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -1037,6 +1037,7 @@ F: arch/arm64/boot/dts/amd/
>
> AMD XGBE DRIVER
> M: Tom Lendacky <[email protected]>
> +M: Shyam Sundar S K <[email protected]>

While this is a valid email address, get_maintainer assumes
name formats use "first middle last" when parsing a name
before an email address. (look around line 2460 in get_maintainer)

Perhaps this should use quotes around the name like:

M: "Shyam Sundar S K" <[email protected]>

2022-07-13 22:59:06

by Tom Lendacky

Subject: Re: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

On 6/28/22 12:37, Joe Perches wrote:
> On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
>> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
>> network device driver.
>>
>> Cc: Shyam Sundar S K <[email protected]>
>> Signed-off-by: Tom Lendacky <[email protected]>
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -1037,6 +1037,7 @@ F: arch/arm64/boot/dts/amd/
>>
>> AMD XGBE DRIVER
>> M: Tom Lendacky <[email protected]>
>> +M: Shyam Sundar S K <[email protected]>
>
> While this is a valid email address, get_maintainer assumes
> name formats use "first middle last" when parsing a name
> before an email address. (look around line 2460 in get_maintainer)
>
> Perhaps this should use quotes around the name like:
>
> M: "Shyam Sundar S K" <[email protected]>

Totally lost this in my Inbox, I'll submit a v2 with the quotes.

Thanks,
Tom

>
>