2021-05-19 18:41:38

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the block tree

Hi all,

In commit

1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")

Fixes tag

Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

or

Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-05-19 20:23:17

by Sergey Shtylyov

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the block tree

Hello!

On 5/19/21 1:01 AM, Stephen Rothwell wrote:

[...]
> In commit
>
> 1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")
>
> Fixes tag
>
> Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant
>
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

This one!

> or
>
> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

Perhaps this could be fixed still, Jens?

MBR, Sergey

2021-05-19 21:56:38

by Jens Axboe

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 5/19/21 1:25 PM, Sergey Shtylyov wrote:
> Hello!
>
> On 5/19/21 1:01 AM, Stephen Rothwell wrote:
>
> [...]
>> In commit
>>
>> 1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")
>>
>> Fixes tag
>>
>> Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
>>
>> has these problem(s):
>>
>> - Subject does not match target commit subject
>> Just use
>> git log -1 --format='Fixes: %h ("%s")'
>>
>> Maybe you meant
>>
>> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
>
> This one!
>
>> or
>>
>> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")
>
> Perhaps this could be fixed still, Jens?

Yep, I fixed it up, thanks.

--
Jens Axboe