2020-06-13 07:17:22

by Jan Kiszka

[permalink] [raw]

Subject: [PATCH] leds: trigger: gpio: Avoid warning on update of inverted

---

From: Jan Kiszka <[email protected]>

If the GPIO has not been configured yet, writing to inverted will raise
a kernel warning.

Signed-off-by: Jan Kiszka <[email protected]>
---
drivers/leds/trigger/ledtrig-gpio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c
index dc64679b1a92..0120faa3dafa 100644
--- a/drivers/leds/trigger/ledtrig-gpio.c
+++ b/drivers/leds/trigger/ledtrig-gpio.c
@@ -99,7 +99,8 @@ static ssize_t gpio_trig_inverted_store(struct device *dev,
gpio_data->inverted = inverted;

/* After inverting, we need to update the LED. */
- gpio_trig_irq(0, led);
+ if (gpio_is_valid(gpio_data->gpio))
+ gpio_trig_irq(0, led);

return n;
}
--
2.26.2

2020-07-12 08:10:01

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH] leds: trigger: gpio: Avoid warning on update of inverted

---

On Sat 2020-06-13 09:15:06, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> If the GPIO has not been configured yet, writing to inverted will raise
> a kernel warning.
>
> Signed-off-by: Jan Kiszka <[email protected]>

Thanks, applied.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

---

Attachments:

(No filename) (432.00 B)
signature.asc (188.00 B)
Digital signature Download all attachments