2022-09-07 18:09:34

by Moger, Babu

Subject: [PATCH v4 04/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA

Adds a new resource type RDT_RESOURCE_SMBA to handle the QoS
enforcement policies on the external slow memory.

Signed-off-by: Babu Moger <[email protected]>
---
arch/x86/kernel/cpu/resctrl/core.c | 12 ++++++++++++
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
2 files changed, 13 insertions(+)

diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index c2657754672e..a7e9aabff8c8 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -100,6 +100,18 @@ struct rdt_hw_resource rdt_resources_all[] = {
.fflags = RFTYPE_RES_MB,
},
},
+ [RDT_RESOURCE_SMBA] =
+ {
+ .r_resctrl = {
+ .rid = RDT_RESOURCE_SMBA,
+ .name = "SMBA",
+ .cache_level = 3,
+ .domains = domain_init(RDT_RESOURCE_SMBA),
+ .parse_ctrlval = parse_bw,
+ .format_str = "%d=%*u",
+ .fflags = RFTYPE_RES_MB,
+ },
+ },
};

/*
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 1d647188a43b..24a1dfeb6cb2 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -418,6 +418,7 @@ enum resctrl_res_level {
RDT_RESOURCE_L3,
RDT_RESOURCE_L2,
RDT_RESOURCE_MBA,
+ RDT_RESOURCE_SMBA,

/* Must be the last */
RDT_NUM_RESOURCES,

2022-09-16 16:02:24

by Reinette Chatre

Subject: Re: [PATCH v4 04/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA

Hi Babu,

On 9/7/2022 11:00 AM, Babu Moger wrote:
> Adds a new resource type RDT_RESOURCE_SMBA to handle the QoS

(nitpick) Adds -> Add

> enforcement policies on the external slow memory.
>
> Signed-off-by: Babu Moger <[email protected]>
> ---

Apart from nitpick this looks good.

Reinette

2022-09-16 19:59:00

by Moger, Babu

Subject: RE: [PATCH v4 04/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA

[AMD Official Use Only - General]



> -----Original Message-----
> From: Reinette Chatre <[email protected]>
> Sent: Friday, September 16, 2022 10:55 AM
> To: Moger, Babu <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Das1, Sandipan
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v4 04/13] x86/resctrl: Add a new resource type
> RDT_RESOURCE_SMBA
>
> Hi Babu,
>
> On 9/7/2022 11:00 AM, Babu Moger wrote:
> > Adds a new resource type RDT_RESOURCE_SMBA to handle the QoS
>
> (nitpick) Adds -> Add
>
> > enforcement policies on the external slow memory.
> >
> > Signed-off-by: Babu Moger <[email protected]>
> > ---
>
> Apart from nitpick this looks good.

Thank you
Babu Moger