2024-04-30 10:04:41

by syzbot

[permalink] [raw]
Subject: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

Hello,

syzbot found the following issue on:

HEAD commit: 9e4bc4bcae01 Merge tag 'nfs-for-6.9-2' of git://git.linux-..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10937af8980000
kernel config: https://syzkaller.appspot.com/x/.config?x=3714fc09f933e505
dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/b98a742ff5ed/disk-9e4bc4bc.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/207a8191df7c/vmlinux-9e4bc4bc.xz
kernel image: https://storage.googleapis.com/syzbot-assets/7dd86c3ad0ba/bzImage-9e4bc4bc.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

------------[ cut here ]------------
kernel BUG at fs/f2fs/inline.c:258!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI
CPU: 1 PID: 34 Comm: kworker/u8:2 Not tainted 6.9.0-rc6-syzkaller-00012-g9e4bc4bcae01 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Workqueue: writeback wb_workfn (flush-7:2)
RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 6f a5 0b fe e9 d6 fc ff ff e8 25 33 91 07 e8 f0 05 a7 fd 90 <0f> 0b e8 e8 05 a7 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
RSP: 0018:ffffc90000aa68e0 EFLAGS: 00010293
RAX: ffffffff83ef09c0 RBX: 0000000000000001 RCX: ffff888017ebbc00
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90000aa6a10 R08: ffffffff83ef0485 R09: 1ffff1100c270ef5
R10: dffffc0000000000 R11: ffffed100c270ef6 R12: ffffc90000aa6968
R13: 1ffff1100c270ef5 R14: ffffc90000aa6960 R15: ffffc90000aa6970
FS: 0000000000000000(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fc5425ff000 CR3: 000000000e134000 CR4: 0000000000350ef0
Call Trace:
<TASK>
f2fs_write_single_data_page+0xb65/0x1d60 fs/f2fs/data.c:2834
f2fs_write_cache_pages fs/f2fs/data.c:3133 [inline]
__f2fs_write_data_pages fs/f2fs/data.c:3288 [inline]
f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3315
do_writepages+0x35b/0x870 mm/page-writeback.c:2612
__writeback_single_inode+0x165/0x10b0 fs/fs-writeback.c:1650
writeback_sb_inodes+0x905/0x1260 fs/fs-writeback.c:1941
wb_writeback+0x457/0xce0 fs/fs-writeback.c:2117
wb_do_writeback fs/fs-writeback.c:2264 [inline]
wb_workfn+0x410/0x1090 fs/fs-writeback.c:2304
process_one_work kernel/workqueue.c:3254 [inline]
process_scheduled_works+0xa12/0x17c0 kernel/workqueue.c:3335
worker_thread+0x86d/0xd70 kernel/workqueue.c:3416
kthread+0x2f2/0x390 kernel/kthread.c:388
ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 6f a5 0b fe e9 d6 fc ff ff e8 25 33 91 07 e8 f0 05 a7 fd 90 <0f> 0b e8 e8 05 a7 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
RSP: 0018:ffffc90000aa68e0 EFLAGS: 00010293
RAX: ffffffff83ef09c0 RBX: 0000000000000001 RCX: ffff888017ebbc00
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90000aa6a10 R08: ffffffff83ef0485 R09: 1ffff1100c270ef5
R10: dffffc0000000000 R11: ffffed100c270ef6 R12: ffffc90000aa6968
R13: 1ffff1100c270ef5 R14: ffffc90000aa6960 R15: ffffc90000aa6970
FS: 0000000000000000(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2e628000 CR3: 0000000049462000 CR4: 0000000000350ef0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup


2024-06-01 11:50:42

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

syzbot has found a reproducer for the following issue on:

HEAD commit: 0e1980c40b6e Add linux-next specific files for 20240531
git tree: linux-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=146c33d6980000
kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88
dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a9aabc980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14d86426980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/44fb1d8b5978/disk-0e1980c4.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/a66ce5caf0b2/vmlinux-0e1980c4.xz
kernel image: https://storage.googleapis.com/syzbot-assets/8992fc8fe046/bzImage-0e1980c4.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/72a0fa392581/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

F2FS-fs (loop0): Try to recover 1th superblock, ret: 0
F2FS-fs (loop0): Mounted with checkpoint version = 48b305e5
------------[ cut here ]------------
kernel BUG at fs/f2fs/inline.c:258!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
CPU: 1 PID: 5090 Comm: syz-executor430 Not tainted 6.10.0-rc1-next-20240531-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 ff a4 09 fe e9 d6 fc ff ff e8 25 22 9a 07 e8 a0 b7 a3 fd 90 <0f> 0b e8 98 b7 a3 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
RSP: 0018:ffffc9000343eb00 EFLAGS: 00010293
RAX: ffffffff83f2c450 RBX: 0000000000000001 RCX: ffff88807f750000
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc9000343ec30 R08: ffffffff83f2bf15 R09: 1ffff1100f0ed1ad
R10: dffffc0000000000 R11: ffffed100f0ed1ae R12: ffffc9000343eb88
R13: 1ffff1100f0ed1ad R14: ffffc9000343eb80 R15: ffffc9000343eb90
FS: 000055557674e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020002000 CR3: 000000001fb2e000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
f2fs_write_single_data_page+0xbb6/0x1e90 fs/f2fs/data.c:2858
f2fs_write_cache_pages fs/f2fs/data.c:3157 [inline]
__f2fs_write_data_pages fs/f2fs/data.c:3312 [inline]
f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3339
do_writepages+0x35d/0x870 mm/page-writeback.c:2657
filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:397
__filemap_fdatawrite_range mm/filemap.c:430 [inline]
file_write_and_wait_range+0x1aa/0x290 mm/filemap.c:788
f2fs_do_sync_file+0x68a/0x1b10 fs/f2fs/file.c:276
generic_write_sync include/linux/fs.h:2810 [inline]
f2fs_file_write_iter+0x7bd/0x24e0 fs/f2fs/file.c:4935
new_sync_write fs/read_write.c:497 [inline]
vfs_write+0xa72/0xc90 fs/read_write.c:590
ksys_write+0x1a0/0x2c0 fs/read_write.c:643
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fd453a5f779
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc94e03488 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007ffc94e03658 RCX: 00007fd453a5f779
RDX: 0000000000002000 RSI: 0000000020000040 RDI: 0000000000000006
RBP: 00007fd453ad8610 R08: 00007ffc94e03658 R09: 00007ffc94e03658
R10: 00007ffc94e03658 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffc94e03648 R14: 0000000000000001 R15: 0000000000000001
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 ff a4 09 fe e9 d6 fc ff ff e8 25 22 9a 07 e8 a0 b7 a3 fd 90 <0f> 0b e8 98 b7 a3 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
RSP: 0018:ffffc9000343eb00 EFLAGS: 00010293
RAX: ffffffff83f2c450 RBX: 0000000000000001 RCX: ffff88807f750000
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc9000343ec30 R08: ffffffff83f2bf15 R09: 1ffff1100f0ed1ad
R10: dffffc0000000000 R11: ffffed100f0ed1ae R12: ffffc9000343eb88
R13: 1ffff1100f0ed1ad R14: ffffc9000343eb80 R15: ffffc9000343eb90
FS: 000055557674e380(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000056082271e438 CR3: 000000001fb2e000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

2024-06-02 01:16:21

by Chao Yu

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip

On 2024/6/1 19:50, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 0e1980c40b6e Add linux-next specific files for 20240531
> git tree: linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=146c33d6980000
> kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88
> dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a9aabc980000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14d86426980000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/44fb1d8b5978/disk-0e1980c4.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/a66ce5caf0b2/vmlinux-0e1980c4.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/8992fc8fe046/bzImage-0e1980c4.xz
> mounted in repro: https://storage.googleapis.com/syzbot-assets/72a0fa392581/mount_0.gz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: [email protected]
>
> F2FS-fs (loop0): Try to recover 1th superblock, ret: 0
> F2FS-fs (loop0): Mounted with checkpoint version = 48b305e5
> ------------[ cut here ]------------
> kernel BUG at fs/f2fs/inline.c:258!
> Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
> CPU: 1 PID: 5090 Comm: syz-executor430 Not tainted 6.10.0-rc1-next-20240531-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
> RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
> Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 ff a4 09 fe e9 d6 fc ff ff e8 25 22 9a 07 e8 a0 b7 a3 fd 90 <0f> 0b e8 98 b7 a3 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
> RSP: 0018:ffffc9000343eb00 EFLAGS: 00010293
> RAX: ffffffff83f2c450 RBX: 0000000000000001 RCX: ffff88807f750000
> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
> RBP: ffffc9000343ec30 R08: ffffffff83f2bf15 R09: 1ffff1100f0ed1ad
> R10: dffffc0000000000 R11: ffffed100f0ed1ae R12: ffffc9000343eb88
> R13: 1ffff1100f0ed1ad R14: ffffc9000343eb80 R15: ffffc9000343eb90
> FS: 000055557674e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000020002000 CR3: 000000001fb2e000 CR4: 00000000003506f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> f2fs_write_single_data_page+0xbb6/0x1e90 fs/f2fs/data.c:2858
> f2fs_write_cache_pages fs/f2fs/data.c:3157 [inline]
> __f2fs_write_data_pages fs/f2fs/data.c:3312 [inline]
> f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3339
> do_writepages+0x35d/0x870 mm/page-writeback.c:2657
> filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:397
> __filemap_fdatawrite_range mm/filemap.c:430 [inline]
> file_write_and_wait_range+0x1aa/0x290 mm/filemap.c:788
> f2fs_do_sync_file+0x68a/0x1b10 fs/f2fs/file.c:276
> generic_write_sync include/linux/fs.h:2810 [inline]
> f2fs_file_write_iter+0x7bd/0x24e0 fs/f2fs/file.c:4935
> new_sync_write fs/read_write.c:497 [inline]
> vfs_write+0xa72/0xc90 fs/read_write.c:590
> ksys_write+0x1a0/0x2c0 fs/read_write.c:643
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
> RIP: 0033:0x7fd453a5f779
> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007ffc94e03488 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
> RAX: ffffffffffffffda RBX: 00007ffc94e03658 RCX: 00007fd453a5f779
> RDX: 0000000000002000 RSI: 0000000020000040 RDI: 0000000000000006
> RBP: 00007fd453ad8610 R08: 00007ffc94e03658 R09: 00007ffc94e03658
> R10: 00007ffc94e03658 R11: 0000000000000246 R12: 0000000000000001
> R13: 00007ffc94e03648 R14: 0000000000000001 R15: 0000000000000001
> </TASK>
> Modules linked in:
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
> Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 ff a4 09 fe e9 d6 fc ff ff e8 25 22 9a 07 e8 a0 b7 a3 fd 90 <0f> 0b e8 98 b7 a3 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
> RSP: 0018:ffffc9000343eb00 EFLAGS: 00010293
> RAX: ffffffff83f2c450 RBX: 0000000000000001 RCX: ffff88807f750000
> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
> RBP: ffffc9000343ec30 R08: ffffffff83f2bf15 R09: 1ffff1100f0ed1ad
> R10: dffffc0000000000 R11: ffffed100f0ed1ae R12: ffffc9000343eb88
> R13: 1ffff1100f0ed1ad R14: ffffc9000343eb80 R15: ffffc9000343eb90
> FS: 000055557674e380(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 000056082271e438 CR3: 000000001fb2e000 CR4: 00000000003506f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>
>
> ---
> If you want syzbot to run the reproducer, reply with:
> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.

2024-06-02 03:46:15

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
kernel BUG in f2fs_write_inline_data

loop0: detected capacity change from 0 to 40427
F2FS-fs (loop0): Invalid log_blocksize (268), supports only 12
F2FS-fs (loop0): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop0): Found nat_bits in checkpoint
F2FS-fs (loop0): Try to recover 1th superblock, ret: 0
F2FS-fs (loop0): Mounted with checkpoint version = 48b305e5
------------[ cut here ]------------
kernel BUG at fs/f2fs/inline.c:276!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
CPU: 1 PID: 5967 Comm: syz-executor Not tainted 6.9.0-syzkaller-10227-g9ee8c306dc6b #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:276
Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 cf da 09 fe e9 d6 fc ff ff e8 75 68 96 07 e8 30 03 a4 fd 90 <0f> 0b e8 28 03 a4 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
RSP: 0018:ffffc9000352eb20 EFLAGS: 00010293
RAX: ffffffff83f22ec0 RBX: 0000000000000001 RCX: ffff888024a21e00
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc9000352ec50 R08: ffffffff83f22985 R09: 1ffff1100d23c095
R10: dffffc0000000000 R11: ffffed100d23c096 R12: ffffc9000352eba8
R13: 1ffff1100d23c095 R14: ffffc9000352eba0 R15: ffffc9000352ebb0
FS: 00007efdd7bfa6c0(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020002000 CR3: 000000007ac94000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
f2fs_write_single_data_page+0xbb6/0x1e90 fs/f2fs/data.c:2888
f2fs_write_cache_pages fs/f2fs/data.c:3187 [inline]
__f2fs_write_data_pages fs/f2fs/data.c:3342 [inline]
f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3369
do_writepages+0x359/0x870 mm/page-writeback.c:2634
filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:397
__filemap_fdatawrite_range mm/filemap.c:430 [inline]
file_write_and_wait_range+0x1aa/0x290 mm/filemap.c:788
f2fs_do_sync_file+0x68a/0x1ae0 fs/f2fs/file.c:276
generic_write_sync include/linux/fs.h:2806 [inline]
f2fs_file_write_iter+0x7bd/0x24e0 fs/f2fs/file.c:4977
call_write_iter include/linux/fs.h:2114 [inline]
new_sync_write fs/read_write.c:497 [inline]
vfs_write+0xa72/0xc90 fs/read_write.c:590
ksys_write+0x1a0/0x2c0 fs/read_write.c:643
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7efdd6e7cee9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007efdd7bfa0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007efdd6fb3fa0 RCX: 00007efdd6e7cee9
RDX: 0000000000002000 RSI: 0000000020000040 RDI: 0000000000000006
RBP: 00007efdd6ec947f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007efdd6fb3fa0 R15: 00007ffd0e21ca28
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:276
Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 cf da 09 fe e9 d6 fc ff ff e8 75 68 96 07 e8 30 03 a4 fd 90 <0f> 0b e8 28 03 a4 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
RSP: 0018:ffffc9000352eb20 EFLAGS: 00010293
RAX: ffffffff83f22ec0 RBX: 0000000000000001 RCX: ffff888024a21e00
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc9000352ec50 R08: ffffffff83f22985 R09: 1ffff1100d23c095
R10: dffffc0000000000 R11: ffffed100d23c096 R12: ffffc9000352eba8
R13: 1ffff1100d23c095 R14: ffffc9000352eba0 R15: ffffc9000352ebb0
FS: 00007efdd7bfa6c0(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020002000 CR3: 000000007ac94000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


Tested on:

commit: 9ee8c306 f2fs: fix to truncate preallocated blocks in ..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip
console output: https://syzkaller.appspot.com/x/log.txt?x=12ab0a4a980000
kernel config: https://syzkaller.appspot.com/x/.config?x=48a63c58ee55467e
dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.

2024-06-02 11:49:37

by Hillf Danton

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

On Sat, 01 Jun 2024 04:50:27 -0700
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 0e1980c40b6e Add linux-next specific files for 20240531
> git tree: linux-next
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14d86426980000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master

--- x/fs/f2fs/data.c
+++ y/fs/f2fs/data.c
@@ -2854,7 +2854,7 @@ write:
set_inode_flag(inode, FI_HOT_DATA);

err = -EAGAIN;
- if (f2fs_has_inline_data(inode)) {
+ if (f2fs_has_inline_data(inode) && !page->index) {
err = f2fs_write_inline_data(inode, page);
if (!err)
goto out;
--

2024-06-02 12:24:16

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: [email protected]

Tested on:

commit: 0e1980c4 Add linux-next specific files for 20240531
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=109d8d64980000
kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88
dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=1662e9c2980000

Note: testing is done by a robot and is best-effort only.

2024-06-02 14:27:36

by Chao Yu

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip

On 2024/6/1 19:50, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 0e1980c40b6e Add linux-next specific files for 20240531
> git tree: linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=146c33d6980000
> kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88
> dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a9aabc980000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14d86426980000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/44fb1d8b5978/disk-0e1980c4.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/a66ce5caf0b2/vmlinux-0e1980c4.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/8992fc8fe046/bzImage-0e1980c4.xz
> mounted in repro: https://storage.googleapis.com/syzbot-assets/72a0fa392581/mount_0.gz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: [email protected]
>
> F2FS-fs (loop0): Try to recover 1th superblock, ret: 0
> F2FS-fs (loop0): Mounted with checkpoint version = 48b305e5
> ------------[ cut here ]------------
> kernel BUG at fs/f2fs/inline.c:258!
> Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
> CPU: 1 PID: 5090 Comm: syz-executor430 Not tainted 6.10.0-rc1-next-20240531-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
> RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
> Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 ff a4 09 fe e9 d6 fc ff ff e8 25 22 9a 07 e8 a0 b7 a3 fd 90 <0f> 0b e8 98 b7 a3 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
> RSP: 0018:ffffc9000343eb00 EFLAGS: 00010293
> RAX: ffffffff83f2c450 RBX: 0000000000000001 RCX: ffff88807f750000
> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
> RBP: ffffc9000343ec30 R08: ffffffff83f2bf15 R09: 1ffff1100f0ed1ad
> R10: dffffc0000000000 R11: ffffed100f0ed1ae R12: ffffc9000343eb88
> R13: 1ffff1100f0ed1ad R14: ffffc9000343eb80 R15: ffffc9000343eb90
> FS: 000055557674e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000020002000 CR3: 000000001fb2e000 CR4: 00000000003506f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> f2fs_write_single_data_page+0xbb6/0x1e90 fs/f2fs/data.c:2858
> f2fs_write_cache_pages fs/f2fs/data.c:3157 [inline]
> __f2fs_write_data_pages fs/f2fs/data.c:3312 [inline]
> f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3339
> do_writepages+0x35d/0x870 mm/page-writeback.c:2657
> filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:397
> __filemap_fdatawrite_range mm/filemap.c:430 [inline]
> file_write_and_wait_range+0x1aa/0x290 mm/filemap.c:788
> f2fs_do_sync_file+0x68a/0x1b10 fs/f2fs/file.c:276
> generic_write_sync include/linux/fs.h:2810 [inline]
> f2fs_file_write_iter+0x7bd/0x24e0 fs/f2fs/file.c:4935
> new_sync_write fs/read_write.c:497 [inline]
> vfs_write+0xa72/0xc90 fs/read_write.c:590
> ksys_write+0x1a0/0x2c0 fs/read_write.c:643
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
> RIP: 0033:0x7fd453a5f779
> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007ffc94e03488 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
> RAX: ffffffffffffffda RBX: 00007ffc94e03658 RCX: 00007fd453a5f779
> RDX: 0000000000002000 RSI: 0000000020000040 RDI: 0000000000000006
> RBP: 00007fd453ad8610 R08: 00007ffc94e03658 R09: 00007ffc94e03658
> R10: 00007ffc94e03658 R11: 0000000000000246 R12: 0000000000000001
> R13: 00007ffc94e03648 R14: 0000000000000001 R15: 0000000000000001
> </TASK>
> Modules linked in:
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258
> Code: ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c e3 fc ff ff 48 89 df e8 ff a4 09 fe e9 d6 fc ff ff e8 25 22 9a 07 e8 a0 b7 a3 fd 90 <0f> 0b e8 98 b7 a3 fd 90 0f 0b 0f 1f 44 00 00 90 90 90 90 90 90 90
> RSP: 0018:ffffc9000343eb00 EFLAGS: 00010293
> RAX: ffffffff83f2c450 RBX: 0000000000000001 RCX: ffff88807f750000
> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
> RBP: ffffc9000343ec30 R08: ffffffff83f2bf15 R09: 1ffff1100f0ed1ad
> R10: dffffc0000000000 R11: ffffed100f0ed1ae R12: ffffc9000343eb88
> R13: 1ffff1100f0ed1ad R14: ffffc9000343eb80 R15: ffffc9000343eb90
> FS: 000055557674e380(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 000056082271e438 CR3: 000000001fb2e000 CR4: 00000000003506f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>
>
> ---
> If you want syzbot to run the reproducer, reply with:
> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.

2024-06-02 15:30:15

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [f2fs?] kernel BUG in f2fs_write_inline_data

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: [email protected]

Tested on:

commit: 9c84cdc8 f2fs: fix return value of f2fs_convert_inline..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip
console output: https://syzkaller.appspot.com/x/log.txt?x=15e10032980000
kernel config: https://syzkaller.appspot.com/x/.config?x=48a63c58ee55467e
dashboard link: https://syzkaller.appspot.com/bug?extid=848062ba19c8782ca5c8
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.
Note: testing is done by a robot and is best-effort only.