LinuxLists.cc - linux-next: Fixes tag needs some work in the hid tree

2021-11-22 21:17:28

Subject: linux-next: Fixes tag needs some work in the hid tree

Hi all,

In commit

3e6a950d9836 ("HID: input: set usage type to key on keycode remap")

Fixes tag

Fixes: bcfa8d1457 ("HID: input: Add support for Programmable Buttons")

has these problem(s):

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

Fixes tag

Fixes: f5854fad39 ("Input: hid-input - allow mapping unknown usages")

has these problem(s):

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (488.00 B)
OpenPGP digital signature

2021-11-22 22:59:34

by Thomas Weißschuh

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the hid tree

Hi Stephen,

On 2021-11-23 08:17+1100, Stephen Rothwell wrote:
> In commit
>
> 3e6a950d9836 ("HID: input: set usage type to key on keycode remap")
>
> Fixes tag
>
> Fixes: bcfa8d1457 ("HID: input: Add support for Programmable Buttons")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").

Thanks for the pointer. I'll make sure to do this correctly in the future.
Maybe this should be part of checkpatch.pl?

> Fixes tag
>
> Fixes: f5854fad39 ("Input: hid-input - allow mapping unknown usages")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").

Thomas