Changes in v2:
- Rebased over media_stage master as of 05/10/2023
- Reworked description of mediatek,scp property in bindings
- Dropped Conor's and Chen-Yu's R-b tags from bindings patch due
to the description rework.
Especially now that Multi-Core SCP support has landed, it makes sense to
retrieve the SCP handle by using the "mediatek,scp" property (as already
done in MediaTek VCODEC), both to select one specific SCP core for MDP3
and to avoid walking the parent node to find a SCP node.
AngeloGioacchino Del Regno (2):
media: dt-bindings: mediatek: Add phandle to mediatek,scp on MDP3 RDMA
media: platform: mtk-mdp3: Use devicetree phandle to retrieve SCP
.../bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++
.../media/platform/mediatek/mdp3/mtk-mdp3-core.c | 16 ++++++++++------
2 files changed, 18 insertions(+), 6 deletions(-)
--
2.42.0
The MDP3 RDMA needs to communicate with the SCP remote processor: allow
specifying a phandle to a SCP core.
Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
---
v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed
the description (so, the patch actually changed a bit).
.../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index 7032c7e15039..59dcea797b71 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -45,6 +45,14 @@ properties:
include/dt-bindings/gce/<chip>-gce.h of each chips.
$ref: /schemas/types.yaml#/definitions/uint32-array
+ mediatek,scp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Phandle to the System Control Processor (SCP) used for initializing
+ and stopping the MDP3, for sending frame data locations to the MDP3's
+ VPU and to install Inter-Processor Interrupt handlers to control
+ processing states.
+
power-domains:
maxItems: 1
--
2.42.0
On Thu, Oct 05, 2023 at 12:49:04PM +0200, AngeloGioacchino Del Regno wrote:
> The MDP3 RDMA needs to communicate with the SCP remote processor: allow
> specifying a phandle to a SCP core.
>
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
> ---
>
> v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed
> the description (so, the patch actually changed a bit).
I dunno, you made it more informative so you could probably have kept
mine at least.
Reviewed-by: Conor Dooley <[email protected]>
Thanks,
Conor.
>
> .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> index 7032c7e15039..59dcea797b71 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -45,6 +45,14 @@ properties:
> include/dt-bindings/gce/<chip>-gce.h of each chips.
> $ref: /schemas/types.yaml#/definitions/uint32-array
>
> + mediatek,scp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Phandle to the System Control Processor (SCP) used for initializing
> + and stopping the MDP3, for sending frame data locations to the MDP3's
> + VPU and to install Inter-Processor Interrupt handlers to control
> + processing states.
> +
> power-domains:
> maxItems: 1
>
> --
> 2.42.0
>
Reviewed-by: Alexandre Mergnat <[email protected]>
On 05/10/2023 12:49, AngeloGioacchino Del Regno wrote:
> The MDP3 RDMA needs to communicate with the SCP remote processor: allow
> specifying a phandle to a SCP core.
--
Regards,
Alexandre
Il 06/10/23 01:36, Conor Dooley ha scritto:
> On Thu, Oct 05, 2023 at 12:49:04PM +0200, AngeloGioacchino Del Regno wrote:
>> The MDP3 RDMA needs to communicate with the SCP remote processor: allow
>> specifying a phandle to a SCP core.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
>> ---
>>
>> v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed
>> the description (so, the patch actually changed a bit).
>
> I dunno, you made it more informative so you could probably have kept
> mine at least.
> Reviewed-by: Conor Dooley <[email protected]>
>
I just wanted to be cautious with keeping Reviewed-by tags.
Sometimes it's better to drop than unfairly keeping, I'm sure that you
understand my point here.
Btw, thank you!
Cheers,
Angelo
> Thanks,
> Conor.
>
>>
>> .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
>> index 7032c7e15039..59dcea797b71 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
>> @@ -45,6 +45,14 @@ properties:
>> include/dt-bindings/gce/<chip>-gce.h of each chips.
>> $ref: /schemas/types.yaml#/definitions/uint32-array
>>
>> + mediatek,scp:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to the System Control Processor (SCP) used for initializing
>> + and stopping the MDP3, for sending frame data locations to the MDP3's
>> + VPU and to install Inter-Processor Interrupt handlers to control
>> + processing states.
>> +
>> power-domains:
>> maxItems: 1
>>
>> --
>> 2.42.0
>>
>>
>> _______________________________________________
>> Kernel mailing list -- [email protected]
>> To unsubscribe send an email to [email protected]
On Wed, Oct 11, 2023 at 01:44:24PM +0200, AngeloGioacchino Del Regno wrote:
> Il 06/10/23 01:36, Conor Dooley ha scritto:
> > On Thu, Oct 05, 2023 at 12:49:04PM +0200, AngeloGioacchino Del Regno wrote:
> > > The MDP3 RDMA needs to communicate with the SCP remote processor: allow
> > > specifying a phandle to a SCP core.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
> > > ---
> > >
> > > v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed
> > > the description (so, the patch actually changed a bit).
> >
> > I dunno, you made it more informative so you could probably have kept
> > mine at least.
> > Reviewed-by: Conor Dooley <[email protected]>
> >
>
> I just wanted to be cautious with keeping Reviewed-by tags.
>
> Sometimes it's better to drop than unfairly keeping, I'm sure that you
> understand my point here.
Oh aye, I do... And you did call out having dropped the tag, so I
appreciate that too.
> Btw, thank you!
nw chief