2019-03-29 15:50:55

by Yannick FERTRE

Subject: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init

Interrupt register must be disabled before call of
devm_request_threaded_irq function to avoid dummy interruption.

Signed-off-by: Yannick Fertré <[email protected]>
---
drivers/gpu/drm/stm/ltdc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index b1741a9..ef5b4d6 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -1118,6 +1118,10 @@ int ltdc_load(struct drm_device *ddev)
goto err;
}

+ /* Disable interrupts */
+ reg_clear(ldev->regs, LTDC_IER,
+ IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
+
for (i = 0; i < MAX_IRQ; i++) {
irq = platform_get_irq(pdev, i);
if (irq < 0)
@@ -1138,10 +1142,6 @@ int ltdc_load(struct drm_device *ddev)
reset_control_deassert(rstc);
}

- /* Disable interrupts */
- reg_clear(ldev->regs, LTDC_IER,
- IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
-
ret = ltdc_get_caps(ddev);
if (ret) {
DRM_ERROR("hardware identifier (0x%08x) not supported!\n",
--
2.7.4

2019-04-01 09:21:07

by Philippe Cornu

Subject: Re: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init

On 3/29/19 4:48 PM, Yannick Fertré wrote:
> Interrupt register must be disabled before call of
> devm_request_threaded_irq function to avoid dummy interruption.
>
> Signed-off-by: Yannick Fertré <[email protected]>
> ---
> drivers/gpu/drm/stm/ltdc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..ef5b4d6 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1118,6 +1118,10 @@ int ltdc_load(struct drm_device *ddev)
> goto err;
> }
>
> + /* Disable interrupts */
> + reg_clear(ldev->regs, LTDC_IER,
> + IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> +
> for (i = 0; i < MAX_IRQ; i++) {
> irq = platform_get_irq(pdev, i);
> if (irq < 0)
> @@ -1138,10 +1142,6 @@ int ltdc_load(struct drm_device *ddev)
> reset_control_deassert(rstc);
> }
>
> - /* Disable interrupts */
> - reg_clear(ldev->regs, LTDC_IER,
> - IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> -

Dear Yannick,
Thank you for your patch,

Acked-by: Philippe Cornu <[email protected]>

Philippe :-)

> ret = ltdc_get_caps(ddev);
> if (ret) {
> DRM_ERROR("hardware identifier (0x%08x) not supported!\n",
>

2019-04-24 19:37:29

by Benjamin Gaignard

Subject: Re: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init

Le lun. 1 avr. 2019 à 11:19, Philippe CORNU <[email protected]> a écrit :
>
>
> On 3/29/19 4:48 PM, Yannick Fertré wrote:
> > Interrupt register must be disabled before call of
> > devm_request_threaded_irq function to avoid dummy interruption.
> >
> > Signed-off-by: Yannick Fertré <[email protected]>
> > ---
> > drivers/gpu/drm/stm/ltdc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..ef5b4d6 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -1118,6 +1118,10 @@ int ltdc_load(struct drm_device *ddev)
> > goto err;
> > }
> >
> > + /* Disable interrupts */
> > + reg_clear(ldev->regs, LTDC_IER,
> > + IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> > +
> > for (i = 0; i < MAX_IRQ; i++) {
> > irq = platform_get_irq(pdev, i);
> > if (irq < 0)
> > @@ -1138,10 +1142,6 @@ int ltdc_load(struct drm_device *ddev)
> > reset_control_deassert(rstc);
> > }
> >
> > - /* Disable interrupts */
> > - reg_clear(ldev->regs, LTDC_IER,
> > - IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> > -
>
> Dear Yannick,
> Thank you for your patch,
>
> Acked-by: Philippe Cornu <[email protected]>
>

Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :-)
>
> > ret = ltdc_get_caps(ddev);
> > if (ret) {
> > DRM_ERROR("hardware identifier (0x%08x) not supported!\n",
> >
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel