2022-04-22 21:29:11

by Srinivasa Rao Mandadapu

Subject: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

Add ldo_l17b in pm7325 regulator, which is required for
wcd codec vdd buck supply.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Co-developed-by: Venkata Prasad Potturu <[email protected]>
Signed-off-by: Venkata Prasad Potturu <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index b833ba1..17d0c05 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -113,6 +113,11 @@
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};

+ vreg_l17b_1p8: ldo17 {
+ regulator-min-microvolt = <1700000>;
+ regulator-max-microvolt = <1900000>;
+ };
+
vdd_px_wcd9385:
vdd_txrx:
vddpx_0:
--
2.7.4

2022-04-24 03:28:32

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

On Thu 21 Apr 09:19 CDT 2022, Srinivasa Rao Mandadapu wrote:

> Add ldo_l17b in pm7325 regulator, which is required for
> wcd codec vdd buck supply.
>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Co-developed-by: Venkata Prasad Potturu <[email protected]>
> Signed-off-by: Venkata Prasad Potturu <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index b833ba1..17d0c05 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -113,6 +113,11 @@
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> + vreg_l17b_1p8: ldo17 {
> + regulator-min-microvolt = <1700000>;
> + regulator-max-microvolt = <1900000>;

Can you confirm that this doesn't need to be in HPM mode?

Thanks,
Bjorn

> + };
> +
> vdd_px_wcd9385:
> vdd_txrx:
> vddpx_0:
> --
> 2.7.4
>

2022-04-25 09:40:50

by Srinivasa Rao Mandadapu

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

On 4/23/2022 9:28 PM, Bjorn Andersson wrote:
Thanks for your time Bjorn!!
> On Thu 21 Apr 09:19 CDT 2022, Srinivasa Rao Mandadapu wrote:
>
>> Add ldo_l17b in pm7325 regulator, which is required for
>> wcd codec vdd buck supply.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
>> Co-developed-by: Venkata Prasad Potturu <[email protected]>
>> Signed-off-by: Venkata Prasad Potturu <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> index b833ba1..17d0c05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> @@ -113,6 +113,11 @@
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> };
>>
>> + vreg_l17b_1p8: ldo17 {
>> + regulator-min-microvolt = <1700000>;
>> + regulator-max-microvolt = <1900000>;
> Can you confirm that this doesn't need to be in HPM mode?
HPM mode included and sent V2 patch.
>
> Thanks,
> Bjorn
>
>> + };
>> +
>> vdd_px_wcd9385:
>> vdd_txrx:
>> vddpx_0:
>> --
>> 2.7.4
>>