2022-04-06 15:49:00

by Ming Qian

Subject: [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg

Wait finishing jpeg job before system sleep,
otherwise the encoding/decoding can't be resumed after suspend.

Signed-off-by: Ming Qian <[email protected]>
---
.../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index ccc26372e178..3df51d866011 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -2356,9 +2356,33 @@ static int mxc_jpeg_runtime_suspend(struct device *dev)
}
#endif

+#ifdef CONFIG_PM_SLEEP
+static int mxc_jpeg_suspend(struct device *dev)
+{
+ struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
+
+ v4l2_m2m_suspend(jpeg->m2m_dev);
+ return pm_runtime_force_suspend(dev);
+}
+
+static int mxc_jpeg_resume(struct device *dev)
+{
+ struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
+ int ret;
+
+ ret = pm_runtime_force_resume(dev);
+ if (ret < 0)
+ return ret;
+
+ v4l2_m2m_resume(jpeg->m2m_dev);
+ return ret;
+}
+#endif
+
static const struct dev_pm_ops mxc_jpeg_pm_ops = {
SET_RUNTIME_PM_OPS(mxc_jpeg_runtime_suspend,
mxc_jpeg_runtime_resume, NULL)
+ SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume)
};

static int mxc_jpeg_remove(struct platform_device *pdev)
--
2.33.0

2022-04-23 01:01:34

by Mirela Rabulea OSS

Subject: Re: [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg

On 06.04.2022 12:47, Ming Qian wrote:
> Wait finishing jpeg job before system sleep,
> otherwise the encoding/decoding can't be resumed after suspend.
>
> Signed-off-by: Ming Qian <[email protected]>

Reviewed-by: Mirela Rabulea <[email protected]>

> ---
> .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index ccc26372e178..3df51d866011 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2356,9 +2356,33 @@ static int mxc_jpeg_runtime_suspend(struct device *dev)
> }
> #endif
>
> +#ifdef CONFIG_PM_SLEEP
> +static int mxc_jpeg_suspend(struct device *dev)
> +{
> + struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
> +
> + v4l2_m2m_suspend(jpeg->m2m_dev);
> + return pm_runtime_force_suspend(dev);
> +}
> +
> +static int mxc_jpeg_resume(struct device *dev)
> +{
> + struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = pm_runtime_force_resume(dev);
> + if (ret < 0)
> + return ret;
> +
> + v4l2_m2m_resume(jpeg->m2m_dev);
> + return ret;
> +}
> +#endif
> +
> static const struct dev_pm_ops mxc_jpeg_pm_ops = {
> SET_RUNTIME_PM_OPS(mxc_jpeg_runtime_suspend,
> mxc_jpeg_runtime_resume, NULL)
> + SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume)
> };
>
> static int mxc_jpeg_remove(struct platform_device *pdev)