2019-07-31 15:37:19

by Guillaume LA ROQUE

Subject: [PATCH v2 3/6] arm64: dts: amlogic: g12: add temperature sensor

Add cpu and ddr temperature sensors for G12 Socs

Signed-off-by: Guillaume La Roque <[email protected]>
---
.../boot/dts/amlogic/meson-g12-common.dtsi | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 06e186ca41e3..7f862a3490fb 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -1353,6 +1353,28 @@
};
};

+ cpu_temp: temperature-sensor@34800 {
+ compatible = "amlogic,g12-cpu-thermal",
+ "amlogic,g12-thermal";
+ reg = <0x0 0x34800 0x0 0x50>;
+ interrupts = <GIC_SPI 35 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&clkc CLKID_TS>;
+ status = "okay";
+ #thermal-sensor-cells = <0>;
+ amlogic,ao-secure = <&sec_AO>;
+ };
+
+ ddr_temp: temperature-sensor@34c00 {
+ compatible = "amlogic,g12-ddr-thermal",
+ "amlogic,g12-thermal";
+ reg = <0x0 0x34c00 0x0 0x50>;
+ interrupts = <GIC_SPI 36 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&clkc CLKID_TS>;
+ status = "okay";
+ #thermal-sensor-cells = <0>;
+ amlogic,ao-secure = <&sec_AO>;
+ };
+
usb2_phy0: phy@36000 {
compatible = "amlogic,g12a-usb2-phy";
reg = <0x0 0x36000 0x0 0x2000>;
--
2.17.1

2019-08-04 03:57:29

by Martin Blumenstingl

Subject: Re: [PATCH v2 3/6] arm64: dts: amlogic: g12: add temperature sensor

Hi Guillaume,

On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque
<[email protected]> wrote:
>
> Add cpu and ddr temperature sensors for G12 Socs
>
> Signed-off-by: Guillaume La Roque <[email protected]>
with the nit-pick below addressed:
Reviewed-by: Martin Blumenstingl <[email protected]>

> ---
> .../boot/dts/amlogic/meson-g12-common.dtsi | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 06e186ca41e3..7f862a3490fb 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1353,6 +1353,28 @@
> };
> };
>
> + cpu_temp: temperature-sensor@34800 {
> + compatible = "amlogic,g12-cpu-thermal",
> + "amlogic,g12-thermal";
> + reg = <0x0 0x34800 0x0 0x50>;
> + interrupts = <GIC_SPI 35 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&clkc CLKID_TS>;
> + status = "okay";
I believe nodes are enabled automatically if they don't have a status property

> + #thermal-sensor-cells = <0>;
> + amlogic,ao-secure = <&sec_AO>;
> + };
> +
> + ddr_temp: temperature-sensor@34c00 {
> + compatible = "amlogic,g12-ddr-thermal",
> + "amlogic,g12-thermal";
> + reg = <0x0 0x34c00 0x0 0x50>;
> + interrupts = <GIC_SPI 36 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&clkc CLKID_TS>;
> + status = "okay";
same here


Martin

2019-08-05 09:42:39

by Guillaume LA ROQUE

Subject: Re: [PATCH v2 3/6] arm64: dts: amlogic: g12: add temperature sensor

hi Martin,


thanks for comments i will fix in v3.


guillaume

On 8/3/19 7:52 PM, Martin Blumenstingl wrote:
> Hi Guillaume,
>
> On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque
> <[email protected]> wrote:
>> Add cpu and ddr temperature sensors for G12 Socs
>>
>> Signed-off-by: Guillaume La Roque <[email protected]>
> with the nit-pick below addressed:
> Reviewed-by: Martin Blumenstingl <[email protected]>
>
>> ---
>> .../boot/dts/amlogic/meson-g12-common.dtsi | 22 +++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> index 06e186ca41e3..7f862a3490fb 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> @@ -1353,6 +1353,28 @@
>> };
>> };
>>
>> + cpu_temp: temperature-sensor@34800 {
>> + compatible = "amlogic,g12-cpu-thermal",
>> + "amlogic,g12-thermal";
>> + reg = <0x0 0x34800 0x0 0x50>;
>> + interrupts = <GIC_SPI 35 IRQ_TYPE_EDGE_RISING>;
>> + clocks = <&clkc CLKID_TS>;
>> + status = "okay";
> I believe nodes are enabled automatically if they don't have a status property
>
>> + #thermal-sensor-cells = <0>;
>> + amlogic,ao-secure = <&sec_AO>;
>> + };
>> +
>> + ddr_temp: temperature-sensor@34c00 {
>> + compatible = "amlogic,g12-ddr-thermal",
>> + "amlogic,g12-thermal";
>> + reg = <0x0 0x34c00 0x0 0x50>;
>> + interrupts = <GIC_SPI 36 IRQ_TYPE_EDGE_RISING>;
>> + clocks = <&clkc CLKID_TS>;
>> + status = "okay";
> same here
>
>
> Martin