2024-06-07 16:30:57

by Judith Mendez

Subject: [PATCH v3 1/8] dt-bindings: counter: Add new ti,am62-eqep compatible

Add new compatible ti,am62-eqep for TI K3 devices. If a device
uses this compatible, require power-domains property.

Since there is only one functional and interface clock for eqep,
clock-names is not really required, so removed from required
section, make it optional for ti,am3352-eqep compatible, and
update the example.

The clock-name also changed for TI K3 SoCs so do not allow
clock-names property for the new compatible.

While we are here, add an example using ti,am62-eqep compatible.

Signed-off-by: Judith Mendez <[email protected]>
Acked-by: Conor Dooley <[email protected]>
---
Changes since v2:
- Make clock-name optional for ti,am3352-eqep compatible
and do not allow for ti,am62-eqep compatible
---
.../devicetree/bindings/counter/ti-eqep.yaml | 44 ++++++++++++++++---
1 file changed, 39 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.yaml b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
index 85f1ff83afe72..54611e06064a2 100644
--- a/Documentation/devicetree/bindings/counter/ti-eqep.yaml
+++ b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
@@ -11,7 +11,9 @@ maintainers:

properties:
compatible:
- const: ti,am3352-eqep
+ enum:
+ - ti,am3352-eqep
+ - ti,am62-eqep

reg:
maxItems: 1
@@ -21,19 +23,35 @@ properties:
maxItems: 1

clocks:
- description: The clock that determines the SYSCLKOUT rate for the eQEP
- peripheral.
+ description: The functional and interface clock that determines the clock
+ rate for the eQEP peripheral.
maxItems: 1

clock-names:
const: sysclkout

+ power-domains:
+ maxItems: 1
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - ti,am62-eqep
+ then:
+ properties:
+ clock-names: false
+
+ required:
+ - power-domains
+
required:
- compatible
- reg
- interrupts
- clocks
- - clock-names

additionalProperties: false

@@ -43,8 +61,24 @@ examples:
compatible = "ti,am3352-eqep";
reg = <0x180 0x80>;
clocks = <&l4ls_gclk>;
- clock-names = "sysclkout";
interrupts = <79>;
};

+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/soc/ti,sci_pm_domain.h>
+
+ bus {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ eqep1: counter@23210000 {
+ compatible = "ti,am62-eqep";
+ reg = <0x00 0x23210000 0x00 0x100>;
+ power-domains = <&k3_pds 60 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 60 0>;
+ interrupts = <GIC_SPI 117 IRQ_TYPE_EDGE_RISING>;
+ status = "disabled";
+ };
+ };
...
--
2.45.1

2024-06-08 13:39:57

by David Lechner

Subject: Re: [PATCH v3 1/8] dt-bindings: counter: Add new ti,am62-eqep compatible

On 6/7/24 11:27 AM, Judith Mendez wrote:
> Add new compatible ti,am62-eqep for TI K3 devices. If a device
> uses this compatible, require power-domains property.
>
> Since there is only one functional and interface clock for eqep,
> clock-names is not really required, so removed from required
> section, make it optional for ti,am3352-eqep compatible, and
> update the example.
>
> The clock-name also changed for TI K3 SoCs so do not allow
> clock-names property for the new compatible.
>
> While we are here, add an example using ti,am62-eqep compatible.
>
> Signed-off-by: Judith Mendez <[email protected]>
> Acked-by: Conor Dooley <[email protected]>
> ---

Reviewed-by: David Lechner <[email protected]>