2022-02-03 22:24:29

by Stefan Wahren

[permalink] [raw]
Subject: Re: [RFC PATCH v4 00/12] Add support for BCM2835 camera interface (unicam)

Hi Jean-Michel,

Am 03.02.22 um 18:49 schrieb Jean-Michel Hautbois:
> Hello !
>
> This patch series adds the BCM2835 CCP2/CSI2 camera interface named
> unicam. This driver is already used in the out-of-tree linux-rpi
> repository [1], and this work aims to support it in mainline.
>
> The series is based on top of:
> - Rebased on top of 5.16 Tomi Valkeinen's multiplexed stream work, on
> his multistream/work branch [2] which has been submitted as v10 at the
> time of this writing. The objective is to demonstrate the use of
> multiplexed streams on a real world widely used example as well as
> supporting unicam mainline.
> - The "Add 12bit and 14bit luma-only formats" series [3] is partly
> applied (the Y10P format bug) the new formats are now part of this
> series.
>
i understand, that you want to have this integrated fast but you send v3
of this series yesterday. This is not enough time for reviewers. Usually
1 to 2 weeks.

Best regards


2022-02-04 09:26:29

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [RFC PATCH v4 00/12] Add support for BCM2835 camera interface (unicam)

Hi Stefan,

On Thu, Feb 03, 2022 at 08:55:42PM +0100, Stefan Wahren wrote:
> Am 03.02.22 um 18:49 schrieb Jean-Michel Hautbois:
> > Hello !
> >
> > This patch series adds the BCM2835 CCP2/CSI2 camera interface named
> > unicam. This driver is already used in the out-of-tree linux-rpi
> > repository [1], and this work aims to support it in mainline.
> >
> > The series is based on top of:
> > - Rebased on top of 5.16 Tomi Valkeinen's multiplexed stream work, on
> > his multistream/work branch [2] which has been submitted as v10 at the
> > time of this writing. The objective is to demonstrate the use of
> > multiplexed streams on a real world widely used example as well as
> > supporting unicam mainline.
> > - The "Add 12bit and 14bit luma-only formats" series [3] is partly
> > applied (the Y10P format bug) the new formats are now part of this
> > series.
>
> i understand, that you want to have this integrated fast but you send v3
> of this series yesterday. This is not enough time for reviewers. Usually
> 1 to 2 weeks.

v3 was incorrectly based on the out-of-tree ISP driver, which caused
some patches to not apply correctly on top of mainline. I've asked
Jean-Michel to fix this and send a v4, as it was difficult to review v3.

--
Regards,

Laurent Pinchart