2023-09-13 11:27:02

by Yassine Oudjana

[permalink] [raw]
Subject: Re: [PATCH v2 12/14] arm64: dts: qcom: msm8996: Remove AGGRE2 clock from SLPI

On 12/09/2023 4:31 pm, Konrad Dybcio wrote:
> The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from
> within the interconnect driver. Attaching it to SLPI was a total hack.
> Get rid of it.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index acef67ab0581..7061a8e12c81 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2433,9 +2433,8 @@ slpi_pil: remoteproc@1c00000 {
> "handover",
> "stop-ack";
>
> - clocks = <&xo_board>,
> - <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
> - clock-names = "xo", "aggre2";
> + clocks = <&xo_board>;
> + clock-names = "xo";
>
> memory-region = <&slpi_mem>;
>

Tested-by: Yassine Oudjana <[email protected]>