2017-09-25 10:42:18

by Arvind Yadav

Subject: [PATCH] dax: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/dax/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 557b9370..30d8a5a 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -118,7 +118,7 @@ int __bdev_dax_supported(struct super_block *sb, int blocksize)
put_dax(dax_dev);

if (len < 1) {
- pr_err("VFS (%s): error: dax access failed (%ld)",
+ pr_err("VFS (%s): error: dax access failed (%ld)\n",
sb->s_id, len);
return len < 0 ? len : -EIO;
}
--
1.9.1

2017-09-25 15:41:54

by Dan Williams

Subject: Re: [PATCH] dax: pr_err() strings should end with newlines

On Mon, Sep 25, 2017 at 3:41 AM, Arvind Yadav <[email protected]> wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Thanks, applied.