2022-05-24 22:28:23

by Jan Beulich

[permalink] [raw]
Subject: Re: [PATCH] xen: switch gnttab_end_foreign_access() to take a struct page pointer

On 24.05.2022 14:41, Juergen Gross wrote:
> Instead of a virtual kernel address use a pointer of the associated
> struct page as second parameter of gnttab_end_foreign_access().
>
> Most users have that pointer available already and are creating the
> virtual address from it, risking problems in case the memory is
> located in highmem.
>
> gnttab_end_foreign_access() itself won't need to get the struct page
> from the address again.
>
> Suggested-by: Jan Beulich <[email protected]>
> Signed-off-by: Juergen Gross <[email protected]>

Reviewed-by: Jan Beulich <[email protected]>