2021-11-15 03:07:45

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] extcon: usb-gpio: fix a non-kernel-doc comment

Do not use "/**" to begin a non-kernel-doc comment.
Fixes this build warning:

drivers/extcon/extcon-usb-gpio.c:23: warning: expecting prototype for drivers/extcon/extcon-usb-gpio.c(). Prototype was for USB_GPIO_DEBOUNCE_MS() instead

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: MyungJoo Ham <[email protected]>
Cc: Chanwoo Choi <[email protected]>
---
drivers/extcon/extcon-usb-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20211102.orig/drivers/extcon/extcon-usb-gpio.c
+++ linux-next-20211102/drivers/extcon/extcon-usb-gpio.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* drivers/extcon/extcon-usb-gpio.c - USB GPIO extcon driver
*
* Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com


2021-12-16 02:37:31

by Chanwoo Choi

[permalink] [raw]
Subject: Re: [PATCH] extcon: usb-gpio: fix a non-kernel-doc comment

On 11/15/21 12:05 PM, Randy Dunlap wrote:
> Do not use "/**" to begin a non-kernel-doc comment.
> Fixes this build warning:
>
> drivers/extcon/extcon-usb-gpio.c:23: warning: expecting prototype for drivers/extcon/extcon-usb-gpio.c(). Prototype was for USB_GPIO_DEBOUNCE_MS() instead
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: MyungJoo Ham <[email protected]>
> Cc: Chanwoo Choi <[email protected]>
> ---
> drivers/extcon/extcon-usb-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20211102.orig/drivers/extcon/extcon-usb-gpio.c
> +++ linux-next-20211102/drivers/extcon/extcon-usb-gpio.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
> * drivers/extcon/extcon-usb-gpio.c - USB GPIO extcon driver
> *
> * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com
>
>

Applied it.

--
Best Regards,
Chanwoo Choi
Samsung Electronics