2021-03-19 03:00:52

by 王擎

Subject: [PATCH] dma-buf: use wake_up_process() instead of wake_up_state()

Using wake_up_process() is more simpler and friendly,
and it is more convenient for analysis and statistics

Signed-off-by: Wang Qing <[email protected]>
---
drivers/dma-buf/dma-fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 7475e09..de51326
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -655,7 +655,7 @@ dma_fence_default_wait_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
struct default_wait_cb *wait =
container_of(cb, struct default_wait_cb, base);

- wake_up_state(wait->task, TASK_NORMAL);
+ wake_up_process(wait->task);
}

/**
--
2.7.4

2021-03-19 08:08:55

by Christian König

Subject: Re: [PATCH] dma-buf: use wake_up_process() instead of wake_up_state()

Am 19.03.21 um 03:58 schrieb Wang Qing:
> Using wake_up_process() is more simpler and friendly,
> and it is more convenient for analysis and statistics
>
> Signed-off-by: Wang Qing <[email protected]>

Reviewed-by: Christian König <[email protected]>

Should I pick it up or do you want to push it through some other tree
than DRM?

Thanks,
Christian.

> ---
> drivers/dma-buf/dma-fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 7475e09..de51326
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -655,7 +655,7 @@ dma_fence_default_wait_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
> struct default_wait_cb *wait =
> container_of(cb, struct default_wait_cb, base);
>
> - wake_up_state(wait->task, TASK_NORMAL);
> + wake_up_process(wait->task);
> }
>
> /**

2021-03-19 08:19:17

by 王擎

Subject: Re:Re: [PATCH] dma-buf: use wake_up_process() instead of wake_up_state()

>> Using wake_up_process() is more simpler and friendly,
>> and it is more convenient for analysis and statistics
>>
>> Signed-off-by: Wang Qing <[email protected]>
>
>Reviewed-by: Christian König <[email protected]>
>
>Should I pick it up or do you want to push it through some other tree
>than DRM?

Pick it up just fine, thanks,
WangQing.

>
>Thanks,
>Christian.