LinuxLists.cc - Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-27 13:57:26

Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

Hi,

My hikey board failed to detect and mount sdcard with v4.9-rc1 and i
have bisected the issue to this patch. Once reverted, the sdcard is
detected again.

Regards,
Vincent

On 25 August 2016 at 05:00, Guodong Xu <[email protected]> wrote:
> Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220
>
> Code and documentation to this property were confirmed by maintainers.
> See:
> [1] https://patchwork.kernel.org/patch/9276607/
> [2] https://patchwork.kernel.org/patch/8487151/
> [3] https://lkml.org/lkml/2016/8/12/91
>
> cc: Jaehoon Chung <[email protected]>
> cc: Rob Herring <[email protected]>
> Signed-off-by: Guodong Xu <[email protected]>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index d0b887a..63608e9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -771,6 +771,7 @@
> interrupts = <0x0 0x48 0x4>;
> clocks = <&sys_ctrl 2>, <&sys_ctrl 1>;
> clock-names = "ciu", "biu";
> + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>;
> bus-width = <0x8>;
> vmmc-supply = <&ldo19>;
> pinctrl-names = "default";
> @@ -790,6 +791,7 @@
> #size-cells = <0x0>;
> clocks = <&sys_ctrl 4>, <&sys_ctrl 3>;
> clock-names = "ciu", "biu";
> + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>;
> vqmmc-supply = <&ldo7>;
> vmmc-supply = <&ldo10>;
> bus-width = <0x4>;
> @@ -807,6 +809,7 @@
> interrupts = <0x0 0x4a 0x4>;
> clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>;
> clock-names = "ciu", "biu";
> + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>;
> bus-width = <0x4>;
> broken-cd;
> pinctrl-names = "default", "idle";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2016-10-27 20:23:14

by John Stultz

[permalink] [raw]

Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

On Thu, Oct 27, 2016 at 6:56 AM, Vincent Guittot
<[email protected]> wrote:
>
> My hikey board failed to detect and mount sdcard with v4.9-rc1 and i
> have bisected the issue to this patch. Once reverted, the sdcard is
> detected again.

Hrm.. I've not seen this w/ my v4.9-rc2 based tree, and I don't have
any mmc patches there.

Can you send me your .config and point me to any other patches you're
running with? Also do you have any details about the card in case its
card specific?

Guodong: Is there any bootloader dependency on that change?

thanks
-john

2016-10-28 06:44:18

On Fri, Oct 28, 2016 at 5:34 AM, Leo Yan <[email protected]> wrote:
> On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote:
>
> [...]
>
>> >> Could you check the below thing..
>> >>
>> >> /* find reset controller when exist */
>> >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
>> >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>> >> if (IS_ERR(pdata->rstc)) {
>> >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>> >> return ERR_PTR(-EPROBE_DEFER);
>> >
>> > Confirmed with this fixing, the kernel can bootup successfully.
>> >
>> > Thanks for this.
>>
>> Thanks for checking this..If this approach is not bad, i will send the patch.
>> Or if there are other good approaches, let me know, plz.
>
> I'd like Guodong and John to confirm for Hikey specific. I have no
> knowledge for this so cannot answer.

No objection from me. I hadn't run into the issue, as I'm not booting
off the sd card.

The patch from Jaehoon doesn't seem to cause trouble in my testing so
far, so I think its worth generating a patch and sending it in for
4.9-rc

thanks
-john