2023-03-19 16:33:31

by Rob Herring (Arm)

Subject: [PATCH] thermal: mediatek: Use of_address_to_resource()

Replace of_get_address() and of_translate_address() calls with single
call to of_address_to_resource().

Signed-off-by: Rob Herring <[email protected]>
---
drivers/thermal/mediatek/auxadc_thermal.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
index ab730f9552d0..c8a3acaf56c1 100644
--- a/drivers/thermal/mediatek/auxadc_thermal.c
+++ b/drivers/thermal/mediatek/auxadc_thermal.c
@@ -897,14 +897,12 @@ static void mtk_thermal_init_bank(struct mtk_thermal *mt, int num,

static u64 of_get_phys_base(struct device_node *np)
{
- u64 size64;
- const __be32 *regaddr_p;
+ struct resource res;

- regaddr_p = of_get_address(np, 0, &size64, NULL);
- if (!regaddr_p)
+ if (of_address_to_resource(np, 0, &res))
return OF_BAD_ADDR;

- return of_translate_address(np, regaddr_p);
+ return res.start;
}

static int mtk_thermal_extract_efuse_v1(struct mtk_thermal *mt, u32 *buf)
--
2.39.2

2023-03-20 09:20:09

by AngeloGioacchino Del Regno

Subject: Re: [PATCH] thermal: mediatek: Use of_address_to_resource()

Il 19/03/23 17:32, Rob Herring ha scritto:
> Replace of_get_address() and of_translate_address() calls with single
> call to of_address_to_resource().
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-04-18 16:31:45

by Rob Herring (Arm)

Subject: Re: [PATCH] thermal: mediatek: Use of_address_to_resource()

On Sun, Mar 19, 2023 at 11:32:31AM -0500, Rob Herring wrote:
> Replace of_get_address() and of_translate_address() calls with single
> call to of_address_to_resource().
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> drivers/thermal/mediatek/auxadc_thermal.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)

Ping!

>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index ab730f9552d0..c8a3acaf56c1 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -897,14 +897,12 @@ static void mtk_thermal_init_bank(struct mtk_thermal *mt, int num,
>
> static u64 of_get_phys_base(struct device_node *np)
> {
> - u64 size64;
> - const __be32 *regaddr_p;
> + struct resource res;
>
> - regaddr_p = of_get_address(np, 0, &size64, NULL);
> - if (!regaddr_p)
> + if (of_address_to_resource(np, 0, &res))
> return OF_BAD_ADDR;
>
> - return of_translate_address(np, regaddr_p);
> + return res.start;
> }
>
> static int mtk_thermal_extract_efuse_v1(struct mtk_thermal *mt, u32 *buf)
> --
> 2.39.2
>

2023-04-19 07:53:54

by Daniel Lezcano

Subject: Re: [PATCH] thermal: mediatek: Use of_address_to_resource()

On 19/03/2023 17:32, Rob Herring wrote:
> Replace of_get_address() and of_translate_address() calls with single
> call to of_address_to_resource().
>
> Signed-off-by: Rob Herring <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog