2023-08-09 12:29:26

by Bryan O'Donoghue

[permalink] [raw]
Subject: [PATCH 6/7] arm64: dts: qcom: apq8016-sbc-d3-camera-mezzanine: Enable the sensor by default

With a standalone mezzanine the sensor ought to be enabled by default.

Signed-off-by: Bryan O'Donoghue <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts
index 6155fa92c717f..ca1b584c0029f 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dts
@@ -44,9 +44,6 @@ camera_rear@3b {
AVDD-supply = <&camera_vdda_2v8>;
DVDD-supply = <&camera_vddd_1v5>;

- /* No camera mezzanine by default */
- status = "disabled";
-
port {
ov5640_ep: endpoint {
data-lanes = <1 2>;
--
2.39.2



2023-08-09 13:06:46

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 6/7] arm64: dts: qcom: apq8016-sbc-d3-camera-mezzanine: Enable the sensor by default

On 9.08.2023 14:04, Bryan O'Donoghue wrote:
> With a standalone mezzanine the sensor ought to be enabled by default.
>
> Signed-off-by: Bryan O'Donoghue <[email protected]>
> ---
imo this should have been squashed into patch 5, with a mention in
the commit message

Konrad