2022-01-14 08:25:43

by Xu Wang

[permalink] [raw]
Subject: [PATCH] media: mtk-mdp: Remove redundant 'flush_workqueue()' calls

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
index 3d38793aaa25..fbd6e06a0567 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
@@ -246,10 +246,8 @@ static int mtk_mdp_remove(struct platform_device *pdev)
mtk_mdp_unregister_m2m_device(mdp);
v4l2_device_unregister(&mdp->v4l2_dev);

- flush_workqueue(mdp->wdt_wq);
destroy_workqueue(mdp->wdt_wq);

- flush_workqueue(mdp->job_wq);
destroy_workqueue(mdp->job_wq);

list_for_each_entry_safe(comp, comp_temp, &mdp->comp_list, node) {
--
2.25.1



Subject: Re: [PATCH] media: mtk-mdp: Remove redundant 'flush_workqueue()' calls

Il 14/01/22 09:22, Xu Wang ha scritto:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Signed-off-by: Xu Wang <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>