On 4/20/22 09:08, Hawkins, Nick wrote:
>
>
> -----Original Message-----
> From: Guenter Roeck [mailto:[email protected]] On Behalf Of Guenter Roeck
> Sent: Wednesday, April 20, 2022 10:53 AM
> To: Hawkins, Nick <[email protected]>; Verdun, Jean-Marie <[email protected]>; Harders, Nick <[email protected]>; [email protected]; [email protected]
> Cc: Wim Van Sebroeck <[email protected]>; Rob Herring <[email protected]>; [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
>
> On 4/20/22 08:01, [email protected] wrote:
>>> From: Nick Hawkins <[email protected]>
>>>
>>> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
>>> This will enable support for the HPE GXP Watchdog
>>>
>>> Signed-off-by: Nick Hawkins <[email protected]>
>>>
>>> ---
>>> v2:
>
>> v3 and v4 changes are missing.
>
> I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?
>
Sorry, I can't parse your statement. If there was no change in v3 and v4,
the change log for v3 and v4 should say "no changes in v3 and v4".
If the changes were made in v3 and/or v4, the change log should say that.
If the patch was added in v2/v3/v4, the change log should say that.
Either case, the last version in the change log should match the version
in the subject. Reviewers won't otherwise know how to match the patch
version with the change log. They will have to dig up v1..v3 to compare
the versions and find that out what exactly changed where (and why).
In my case, that commonly translates to "move patch to the end of my
review queue" because I just don't have the time to do that.
Guenter
-----Original Message-----
From: Guenter Roeck [mailto:[email protected]] On Behalf Of Guenter Roeck
Sent: Wednesday, April 20, 2022 11:37 AM
To: Hawkins, Nick <[email protected]>; Verdun, Jean-Marie <[email protected]>; Harders, Nick <[email protected]>; [email protected]; [email protected]
Cc: Wim Van Sebroeck <[email protected]>; Rob Herring <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
On 4/20/22 09:08, Hawkins, Nick wrote:
>
>
> -----Original Message-----
> From: Guenter Roeck [mailto:[email protected]] On Behalf Of Guenter
> Roeck
> Sent: Wednesday, April 20, 2022 10:53 AM
> To: Hawkins, Nick <[email protected]>; Verdun, Jean-Marie
> <[email protected]>; Harders, Nick <[email protected]>;
> [email protected]; [email protected]
> Cc: Wim Van Sebroeck <[email protected]>; Rob Herring
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP
> Watchdog timer binding
>
> On 4/20/22 08:01, [email protected] wrote:
>>> From: Nick Hawkins <[email protected]>
>>>
>>> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
>>> This will enable support for the HPE GXP Watchdog
>>>
>>> Signed-off-by: Nick Hawkins <[email protected]>
>>>
>>> ---
>>> v2:
>
>> v3 and v4 changes are missing.
>
> I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?
>
> Sorry, I can't parse your statement. If there was no change in v3 and v4, the change log for v3 and v4 should say "no changes in v3 and v4".
> If the changes were made in v3 and/or v4, the change log should say that.
> If the patch was added in v2/v3/v4, the change log should say that.
> Either case, the last version in the change log should match the version in the subject. Reviewers won't otherwise know how to match the patch version with the change log. They will have to dig up v1..v3 to compare the versions and find that out what exactly changed where (and why).
> In my case, that commonly translates to "move patch to the end of my review queue" because I just don't have the time to do that.
Understood, I have gone through the entire patchset and updated versions to be in line with the patchset version number. The places where no changes were made I have put no changes.
Thanks for the feedback,
-Nick