2023-09-15 06:00:20

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH 3/9] arm64: dts: qcom: msm8916-ufi: Drop gps_mem for now

On 11/09/2023 18:41, Stephan Gerhold wrote:
> gps_mem is needed by the modem firmware for GPS to work. However, it is
> accessed via QMI memshare [1] which is not available upstream yet.
> Until it lands upstream reserving this does not provide any advantage.
>
> [1]: https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Signed-off-by: Stephan Gerhold <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
> index c759c0544dd9..69f268db4df9 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
> @@ -22,11 +22,6 @@ mpss_mem: mpss@86800000 {
> reg = <0x0 0x86800000 0x0 0x5500000>;
> no-map;
> };
> -
> - gps_mem: gps@8bd00000 {
> - reg = <0x0 0x8bd00000 0x0 0x200000>;
> - no-map;
> - };
> };
>
> gpio-keys {
>

Should this have a Fixes tag, should probably be applied to stable.

Reviewed-by: Bryan O'Donoghue <[email protected]>