2021-05-10 08:56:43

by Seung-Woo Kim

Subject: [PATCH 2/2] dump.f2fs: fix memory leak caused by dump_node_blk()

Fix to free node_blk when nid is 0 from dump_node_blk().

Signed-off-by: Seung-Woo Kim <[email protected]>
---
fsck/dump.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fsck/dump.c b/fsck/dump.c
index 055ce09bb1cf..042a2e52edca 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -278,7 +278,7 @@ static void dump_node_blk(struct f2fs_sb_info *sbi, int ntype,

if (nid == 0) {
*ofs += skip;
- return;
+ goto out;
}

for (i = 0; i < idx; i++, (*ofs)++) {
@@ -297,6 +297,7 @@ static void dump_node_blk(struct f2fs_sb_info *sbi, int ntype,
break;
}
}
+out:
free(node_blk);
}

--
2.19.2

2021-05-11 03:20:05

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH 2/2] dump.f2fs: fix memory leak caused by dump_node_blk()

On 2021/5/10 16:57, Seung-Woo Kim wrote:
> Fix to free node_blk when nid is 0 from dump_node_blk().
>
> Signed-off-by: Seung-Woo Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,