2022-04-19 00:46:41

by Colin Ian King

Subject: [PATCH] fs/ntfs3: remove redundant assignment to variable vcn

Variable vcn is being assigned a value that is never read, it is
being re-assigned again in the initialization of a for-loop. The
assignment is redundant and can be removed.

Cleans up clang scan build warning:
fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
fs/ntfs3/attrib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
index e8c00dda42ad..fc0623b029e6 100644
--- a/fs/ntfs3/attrib.c
+++ b/fs/ntfs3/attrib.c
@@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
{
struct ntfs_sb_info *sbi = ni->mi.sbi;
u8 cluster_bits = sbi->cluster_bits;
- CLST vcn = from >> cluster_bits;
+ CLST vcn;
CLST vcn_last = (to - 1) >> cluster_bits;
CLST lcn, clen;
int err;
--
2.35.1

2022-04-22 19:36:26

by Kari Argillander

Subject: Re: [PATCH] fs/ntfs3: remove redundant assignment to variable vcn

On 18.4.2022 17.00, Colin Ian King wrote:
> Variable vcn is being assigned a value that is never read, it is
> being re-assigned again in the initialization of a for-loop. The
> assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Kari Argillander <[email protected]>

> ---
> fs/ntfs3/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
> index e8c00dda42ad..fc0623b029e6 100644
> --- a/fs/ntfs3/attrib.c
> +++ b/fs/ntfs3/attrib.c
> @@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
> {
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> u8 cluster_bits = sbi->cluster_bits;
> - CLST vcn = from >> cluster_bits;
> + CLST vcn;
> CLST vcn_last = (to - 1) >> cluster_bits;
> CLST lcn, clen;
> int err;

2022-06-08 16:00:48

by Konstantin Komarov

Subject: Re: [PATCH] fs/ntfs3: remove redundant assignment to variable vcn

On 4/18/22 17:00, Colin Ian King wrote:
> Variable vcn is being assigned a value that is never read, it is
> being re-assigned again in the initialization of a for-loop. The
> assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/ntfs3/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
> index e8c00dda42ad..fc0623b029e6 100644
> --- a/fs/ntfs3/attrib.c
> +++ b/fs/ntfs3/attrib.c
> @@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
> {
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> u8 cluster_bits = sbi->cluster_bits;
> - CLST vcn = from >> cluster_bits;
> + CLST vcn;
> CLST vcn_last = (to - 1) >> cluster_bits;
> CLST lcn, clen;
> int err;

Thanks for patch, applied!