2010-01-18 23:57:58

by Thiago Farina

Subject: [PATCH] lib/dma-debug.c: mark file-local struct symbol static.

warning: symbol 'filter_fops' was not declared. Should it be static?

Signed-off-by: Thiago Farina <[email protected]>
---
lib/dma-debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 7d2f0b3..ba8b670 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -587,7 +587,7 @@ out_unlock:
return count;
}

-const struct file_operations filter_fops = {
+static const struct file_operations filter_fops = {
.read = filter_read,
.write = filter_write,
};
--
1.6.6.201.g56119

2010-01-22 17:01:53

by Joerg Roedel

Subject: Re: [PATCH] lib/dma-debug.c: mark file-local struct symbol static.

On Mon, Jan 18, 2010 at 06:57:33PM -0500, Thiago Farina wrote:
> warning: symbol 'filter_fops' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <[email protected]>
> ---
> lib/dma-debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 7d2f0b3..ba8b670 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -587,7 +587,7 @@ out_unlock:
> return count;
> }
>
> -const struct file_operations filter_fops = {
> +static const struct file_operations filter_fops = {
> .read = filter_read,
> .write = filter_write,
> };

Applied to dma-debug/fixes. Thanks.

Joerg