2022-12-30 04:39:15

by Russell Currey

Subject: [PATCH v2 1/7] powerpc/pseries: Log hcall return codes for PLPKS debug

The plpks code converts hypervisor return codes into their Linux
equivalents so that users can understand them. Having access to the
original return codes is really useful for debugging, so add a
pr_debug() so we don't lose information from the conversion.

Signed-off-by: Russell Currey <[email protected]>
---
arch/powerpc/platforms/pseries/plpks.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
index 9e4401aabf4f..820218eb894f 100644
--- a/arch/powerpc/platforms/pseries/plpks.c
+++ b/arch/powerpc/platforms/pseries/plpks.c
@@ -131,6 +131,8 @@ static int pseries_status_to_err(int rc)
err = -EINVAL;
}

+ pr_debug("Converted hypervisor code %d to Linux %d\n", rc, err);
+
return err;
}

--
2.38.1

2023-01-04 05:09:51

by Andrew Donnellan

Subject: Re: [PATCH v2 1/7] powerpc/pseries: Log hcall return codes for PLPKS debug

On Fri, 2022-12-30 at 15:20 +1100, Russell Currey wrote:
> The plpks code converts hypervisor return codes into their Linux
> equivalents so that users can understand them.  Having access to the
> original return codes is really useful for debugging, so add a
> pr_debug() so we don't lose information from the conversion.
>
> Signed-off-by: Russell Currey <[email protected]>

This is indeed useful to have.

Reviewed-by: Andrew Donnellan <[email protected]>
Tested-by: Andrew Donnellan <[email protected]>

> ---
>  arch/powerpc/platforms/pseries/plpks.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/plpks.c
> b/arch/powerpc/platforms/pseries/plpks.c
> index 9e4401aabf4f..820218eb894f 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -131,6 +131,8 @@ static int pseries_status_to_err(int rc)
>                 err = -EINVAL;
>         }
>  
> +       pr_debug("Converted hypervisor code %d to Linux %d\n", rc,
> err);
> +
>         return err;
>  }
>  

--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited