2021-04-12 18:55:00

by Hui Su

Subject: [PATCH] sched: remove the redundant comments

Since the commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]"),
we don't need this any more.

Signed-off-by: Hui Su <[email protected]>
---
kernel/sched/sched.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 10a1522b1e30..2232022d8561 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
struct rq {
/* runqueue lock: */
raw_spinlock_t lock;
-
- /*
- * nr_running and cpu_load should be in the same cacheline because
- * remote CPUs use both these fields when doing load calculation.
- */
unsigned int nr_running;
#ifdef CONFIG_NUMA_BALANCING
unsigned int nr_numa_running;
--
2.25.1

2021-04-13 09:38:03

by Dietmar Eggemann

Subject: Re: [PATCH] sched: remove the redundant comments

On 12/04/2021 09:39, Hui Su wrote:
> Since the commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]"),
> we don't need this any more.
>
> Signed-off-by: Hui Su <[email protected]>
> ---
> kernel/sched/sched.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 10a1522b1e30..2232022d8561 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> struct rq {
> /* runqueue lock: */
> raw_spinlock_t lock;
> -
> - /*
> - * nr_running and cpu_load should be in the same cacheline because
> - * remote CPUs use both these fields when doing load calculation.
> - */
> unsigned int nr_running;
> #ifdef CONFIG_NUMA_BALANCING
> unsigned int nr_numa_running;

I forgot to remove this snippet back then. LGTM.

Add a

Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")

line.

Reviewed-by: Dietmar Eggemann <[email protected]>

2021-04-14 02:40:54

by Steven Rostedt

Subject: Re: [PATCH] sched: remove the redundant comments

On Tue, 13 Apr 2021 10:36:07 +0200
Dietmar Eggemann <[email protected]> wrote:

> > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> > struct rq {
> > /* runqueue lock: */
> > raw_spinlock_t lock;
> > -
> > - /*
> > - * nr_running and cpu_load should be in the same cacheline because
> > - * remote CPUs use both these fields when doing load calculation.
> > - */
> > unsigned int nr_running;
> > #ifdef CONFIG_NUMA_BALANCING
> > unsigned int nr_numa_running;
>
> I forgot to remove this snippet back then. LGTM.
>
> Add a
>
> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
>
> line.

It's just removing a comment. Should it really need a "Fixes" tag, which
will cause many people to look at it to determine if it should be
backported to stable?

-- Steve

2021-04-14 03:45:35

by Dietmar Eggemann

Subject: Re: [PATCH] sched: remove the redundant comments

On 13/04/2021 18:28, Steven Rostedt wrote:
> On Tue, 13 Apr 2021 10:36:07 +0200
> Dietmar Eggemann <[email protected]> wrote:

[...]

>> Add a
>>
>> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
>>
>> line.
>
> It's just removing a comment. Should it really need a "Fixes" tag, which
> will cause many people to look at it to determine if it should be
> backported to stable?

I see, in this case let's skip it.